Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-07-12 Thread Rob Worsnop
u 28 Jun 2012 01:55:53 PM CDT, Steve Ebersole wrote: >> >>> The plan as of now is to not have a 4.2. >>> >>> Your changes will be in 4.1.5 (if ok). >>> >>> On Thu 28 Jun 2012 01:04:42 PM CDT, Rob Worsnop wrote: >>> >>>> OK, don

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-28 Thread Rob Worsnop
OK, done. I think I covered everything. Assuming my changes are OK, will they be in 4.2? On Mon, Jun 25, 2012 at 11:48 PM, Rob Worsnop wrote: > Oh good. The way I am coding it, the flag will be ignored > if SqlFragmentAlias elements are present. > > > On Mon, Jun 25, 2012 at

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-25 Thread Rob Worsnop
infer 'deduceAliasInjectionPoints' > as being false. > > > On 06/25/2012 08:29 AM, Rob Worsnop wrote: > >> Got it. Earlier you were looking for suggestions for a less verbose name >> for this. How about "autoAliasInjection"? >> >> On Mon, Jun 25, 2012

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-25 Thread Rob Worsnop
ally I think 'autoAliasInjection' is less telling than > 'deduceAliasInjectionPoints'. I guess the question is whether it is still > telling enough that users get a sense of what it means just by name. > > > On Mon 25 Jun 2012 08:29:23 AM CDT, Rob Worsnop wrote: > &

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-25 Thread Rob Worsnop
Hibernate ends up scanning the condition fragment for no reason. > > > On Fri 22 Jun 2012 11:09:31 AM CDT, Rob Worsnop wrote: > >> On Mon, Jun 4, 2012 at 12:14 PM, Steve Ebersole >> wrote: >> >>> 1) I think adding support for {alias} is a more general issue. Its

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-22 Thread Rob Worsnop
On Mon, Jun 4, 2012 at 12:14 PM, Steve Ebersole wrote: > 1) I think adding support for {alias} is a more general issue.  Its > applicable to many other pieces of mapping metadata (@Formula, etc).  More I > was responding to David's comment there.  I totally think it makes sense to > support this i

Re: [hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-06-04 Thread Rob Worsnop
Steve, Thanks for the feedback. Is this a correct summary: * Introduce the "{alias}" placeholder, as in Restrictions.sqlRestriction. * Introduce another optional @Filter element, "entity", which developers could use instead of the proposed "table" element. Thanks, Rob. On Fri, Jun 1, 2012 at 1

[hibernate-dev] Pull request for HHH-2394 (Support filter tag in subclass)

2012-05-30 Thread Rob Worsnop
https://github.com/hibernate/hibernate-orm/pull/339 It seemed that the challenge to overcome was that Hibernate did not know which aliases to use when generating the where clauses for filters. When filters are not allowed on subclasses (current situation), the alias for the root entity is used for