Re: [hibernate-dev] HHH-6044 / HHH-9662 and partial identifier generation - No part of a composite identifier may be null HibernateException

2020-04-21 Thread Jason Pyeron
I spent the whole day tracking down / debugging / updating the org.hibernate.dialect.SQLServer2012Dialect and associated functions. I will continue tomorrow. On a side note SQL Server does not allow the identity column to be specified in the insert. As such the insert SQL statements generated b

Re: [hibernate-dev] HHH-6044 / HHH-9662 and partial identifier generation - No part of a composite identifier may be null HibernateException

2020-04-21 Thread Jason Pyeron
I have been reviewing the change set, I see where Fabio was going. This looks like it will address the Identify vs Sequence issue. That will still leave the IncrediblySillyJpaMapsIdMappedIdentifierValueMarshaller not handling the generation like the NormalMappedIdentifierValueMarshaller does.

Re: [hibernate-dev] HHH-6044 / HHH-9662 and partial identifier generation - No part of a composite identifier may be null HibernateException

2020-04-21 Thread andrea boriero
there is a PR related to this issue ( https://github.com/hibernate/hibernate-orm/pull/3105), you can try to verify if it solves the problem On Tue, 21 Apr 2020 at 16:15, Jason Pyeron wrote: > How can I help on HHH-9662 ? > > I have found that this fails with sequences too, when the composite > i

Re: [hibernate-dev] HHH-6044 / HHH-9662 and partial identifier generation - No part of a composite identifier may be null HibernateException

2020-04-21 Thread Jason Pyeron
How can I help on HHH-9662 ? I have found that this fails with sequences too, when the composite identifier is another entity. This works: @Id @Column(name = "registration_number") @GeneratedValue(strategy = GenerationType.SEQUENCE) private Long registrationNumber; @Id @

Re: [hibernate-dev] HHH-11699 Hibernate ignores 'schema' attribute of @SequenceGenerator for Oracle --- and SQL Server --- sequences

2020-04-21 Thread Jason Pyeron
I cleaned up the test case. My miss report of failure on the setting of false was due to other consequences of setting it to false (e.g. HHH-13939). It does in fact create and use the correct schema when hibernate.id.new_generator_mappings=false . This does not feel like a fix, quoting https:/

Re: [hibernate-dev] HHH-6044 / HHH-9662 and partial identifier generation - No part of a composite identifier may be null HibernateException

2020-04-21 Thread Jason Pyeron
Turns out this issue may be a duplicate of a known issue, taking this over to the dev list. org/hibernate/test/annotations/cid/CompositeIdIdentityTest.java: 7 package org.hibernate.test.annotations.cid; 48 @RequiresDialectFeature(DialectChecks.SupportsIdentityColumns.class) 4

Re: [hibernate-dev] HHH-11699 Hibernate ignores 'schema' attribute of @SequenceGenerator for Oracle --- and SQL Server --- sequences

2020-04-21 Thread Jason Pyeron
Sorry, accidentally sent to Andrea and not the list. From: Jason Pyeron [mailto:jpye...@pdinc.us] Sent: Tuesday, April 21, 2020 8:56 AM To: 'andrea boriero' Subject: RE: [hibernate-dev] HHH-11699 Hibernate ignores 'schema' attribute of @SequenceGenerator for Oracle --- and SQL Server --- seq