Re: [hibernate-dev] Property using field access and has final getter/setter method

2020-03-05 Thread Gail Badner
I created https://hibernate.atlassian.net/browse/HHH-13891. IIUC, a ProxyFactory should not be created if any ID, version, or property method getter/setter is final. I'm working on a PR. Thanks, Gail On Thu, Mar 5, 2020 at 7:56 AM Steve Ebersole wrote: > If any getters or setters are final t

Re: [hibernate-dev] Custom EventType and listeners

2020-03-05 Thread Gail Badner
Thanks for the feedback! I've created https://hibernate.atlassian.net/browse/HHH-13890 . On Thu, Mar 5, 2020 at 7:57 AM Steve Ebersole wrote: > I agree at the high level. > > On Thu, Mar 5, 2020 at 9:17 AM Sanne Grinovero > wrote: > >> Hi Gail, >> >> at high level it seems a reasonable idea to

Re: [hibernate-dev] Custom EventType and listeners

2020-03-05 Thread Steve Ebersole
I agree at the high level. On Thu, Mar 5, 2020 at 9:17 AM Sanne Grinovero wrote: > Hi Gail, > > at high level it seems a reasonable idea to me. > > In more detail, let's make sure the `registeredEventListeners` > initialization is not affected by data races, but we can defer > discussing such de

Re: [hibernate-dev] Property using field access and has final getter/setter method

2020-03-05 Thread Steve Ebersole
If any getters or setters are final then the ProxyFactory cannot be used and imo should not get built, especially moving forward as we could use bytecode-based proxies On Wed, Mar 4, 2020 at 2:11 PM Gail Badner wrote: > This commit [1] for HHH-11838 [2] causes an error to get logged by > ProxyFa

Re: [hibernate-dev] Custom EventType and listeners

2020-03-05 Thread Sanne Grinovero
Hi Gail, at high level it seems a reasonable idea to me. In more detail, let's make sure the `registeredEventListeners` initialization is not affected by data races, but we can defer discussing such details on a PR as that would probably be clearer. Thanks, Sanne On Thu, 5 Mar 2020 at 07:16, Ga