Re: [hibernate-dev] API removal proposal: org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery

2019-08-16 Thread Sanne Grinovero
Hi Gail, thanks for checking all that! And sure I won't delete it out of the blue in a micro, I'd deprecate it first, make a JIRA for removal later, etc etc but first I'd like to hear if someone would prefer me to stay away and leave it there: while I'm failing to see a good reason for this method

Re: [hibernate-dev] API removal proposal: org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery

2019-08-16 Thread Gail Badner
Hi Sanne, I've confirmed that current versions of WildFly and EAP do not call that ResourceRegistry#cancelLastQuery. ResourceRegistry was introduced in 5.0. As of 5.0.16, cancelLastQuery() is not used by Hibernate ORM. At least as far back as 4.2, SessionImpl#cancelQuery called JdbcCoordinator#c

[hibernate-dev] API removal proposal: org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery

2019-08-16 Thread Sanne Grinovero
Hi all, is this method needed? - org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery It seems undocumented, untested, and everything compiles just fine if I just delete it - however it seems marked as API. But also, I suppose this should be invoked by a different thread as the one act