Re: [hibernate-dev] SAP HANA build failing for a while - does it reveal a bug?

2019-01-03 Thread Guillaume Smet
Ah OK, thanks, totally missed that this PR was there to fix these test failures. Let's wait for Chris to be back then. On Thu, Jan 3, 2019 at 11:25 PM Bregler, Jonathan wrote: > Hi, > > These test failures are caused by the fix for > https://hibernate.atlassian.net/browse/HHH-13104. There is so

Re: [hibernate-dev] SAP HANA build failing for a while - does it reveal a bug?

2019-01-03 Thread Bregler, Jonathan
Hi, These test failures are caused by the fix for https://hibernate.atlassian.net/browse/HHH-13104. There is some discussion in the ticket around how to best fix the test failures. Vlad has already opened a PR: https://github.com/hibernate/hibernate-orm/pull/2705 Best, Jonathan -Origina

[hibernate-dev] SAP HANA build failing for a while - does it reveal a bug?

2019-01-03 Thread Guillaume Smet
Hi, Since this build http://ci.hibernate.org/view/ORM/job/hibernate-orm-master-hana-main/688/ , the SAP HANA build is failing consistently. With a lot of tests failing with: Caused by: org.hibernate.MappingException: Unable to build insert statement for table [Employee]: SAP HANA requires at leas

Re: [hibernate-dev] [ORM] Reducing startup log verbosity

2019-01-03 Thread Steve Ebersole
In general I agree with everything you said, but had a few specific comments in line... > [o.h.j.i.u.LogHelper] (main) HHH000204: Processing PersistenceUnitInfo [ > name: templatePU > ...] > > -> so, first, I would make this one a one liner as we apparently didn't add > any other proper