Seems to me it would be better to wait until the whole commit can be
integrated. Just seems like it would be easier to keep track of
On Wed, Dec 19, 2018, 3:25 PM Guillaume Smet
wrote:
> Hi Vlad,
>
> Not sure if it's better to partially push the commits or to have them in a
> list to deal with
Well, I don't think adding the test without the fix is the right thing to
do.
When we will try to make this test work, we will have totally forgotten
that there's a fix needed for that.
That's why I listed the commits we couldn't merge for now as we will have
to merge them later, once the feature
Hi Vlad,
Not sure if it's better to partially push the commits or to have them in a
list to deal with later (tests + commit).
What do the others think about it?
On Wed, Dec 19, 2018 at 6:37 PM Vlad Mihalcea
wrote:
> I have merged some PRs and have some commits still left to integrate into
> 6.
Hi,
We had the first 5 -> 6 merge meeting with Chris yesterday. We
cherry-picked all the simple things but there were a few more problematic
things:
- things that needs to be ported soon but weren't a simple cherry-pick
- things that cannot be ported right now because not yet available in 6
We de