Re: [hibernate-dev] Unresolved issues targeting 5.2.11

2017-08-31 Thread Vlad Mihalcea
Much appreciated, Vlad On Fri, Sep 1, 2017 at 9:19 AM, Gail Badner wrote: > Hi Vlad, > > Thanks for letting me know. I'll take a look tomorrow. > > Regards, > Gail > > On Thu, Aug 31, 2017 at 10:25 PM, Vlad Mihalcea > wrote: > >> Hi Gail, >> >> My issues have Pull Requests that need to be revi

Re: [hibernate-dev] Unresolved issues targeting 5.2.11

2017-08-31 Thread Gail Badner
Hi Vlad, Thanks for letting me know. I'll take a look tomorrow. Regards, Gail On Thu, Aug 31, 2017 at 10:25 PM, Vlad Mihalcea wrote: > Hi Gail, > > My issues have Pull Requests that need to be reviewed. > > However, there are around 8 PRs which I'd like someone to review so that > we can inclu

Re: [hibernate-dev] Unresolved issues targeting 5.2.11

2017-08-31 Thread Vlad Mihalcea
Hi Gail, My issues have Pull Requests that need to be reviewed. However, there are around 8 PRs which I'd like someone to review so that we can include them in 5.2.11: https://github.com/hibernate/hibernate-orm/pulls?q=is%3Aopen+is%3Apr+author%3Avladmihalcea+label%3A%22Ready+for+review%22 Thank

[hibernate-dev] Unresolved issues targeting 5.2.11

2017-08-31 Thread Gail Badner
Unless something critical comes up, I plan release 5.2.11 next week. There are currently 24 unresolved issues. [1] I am CC'ing everyone that is assigned issues that are still unresolved. Please take a moment to move any issues that you know will not be ready for 5.2.11 to 5.2.12. There are also 7

Re: [hibernate-dev] ETA Hibernate-ORM 5.2.11 release?

2017-08-31 Thread Gail Badner
Guillaume and Yoann, FYI, I took a look and added a comment to https://hibernate.atlassian. net/browse/HSEARCH-2865. Regards, Gail On Thu, Aug 31, 2017 at 9:07 AM, Guillaume Smet wrote: > Gail, > > FWIW, I also discovered https://hibernate.atlassian. > net/browse/HSEARCH-2865 today. Let's be

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Guillaume Smet
OK, thanks, I'll submit a PR tomorrow. On Thu, Aug 31, 2017 at 6:21 PM, Steve Ebersole wrote: > Yes, I understand now. That is a good idea. > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hiberna

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Steve Ebersole
Yes, I understand now. That is a good idea. On Thu, Aug 31, 2017 at 11:20 AM Guillaume Smet wrote: > Steve, > > I think you misunderstood my point. Vlad got it. > > addEntity() is part of the NativeQuery API (and was moved to NativeQuery in > your 6 branch). > > It is marked as deprecated for o

Re: [hibernate-dev] ETA Hibernate-ORM 5.2.11 release?

2017-08-31 Thread Guillaume Smet
Gail, FWIW, I also discovered https://hibernate.atlassian.net/browse/HSEARCH-2865 today. Let's be sure it's not an ORM issue before releasing 5.2.11.Final. Yoann is going to take a look at it on Monday so we should be fixed soon. -- Guillaume On Wed, Aug 30, 2017 at 4:48 PM, Guillaume Smet wr

Re: [hibernate-dev] Deprecated methods of NativeQuery via SQLQuery

2017-08-31 Thread Guillaume Smet
Steve, I think you misunderstood my point. Vlad got it. addEntity() is part of the NativeQuery API (and was moved to NativeQuery in your 6 branch). It is marked as deprecated for our users because it is only present in SQLQuery which is marked as deprecated. I think the methods that will be kep