Re: [hibernate-dev] SqlTypeDescriptor bind by name limitation

> > A CallableStatement is also a PreparedStatement so we already know how to > bind positionally against both PreparedStatement (and CallableStatement, > since they are PreparedStatement). And only for CallableStatement does > JDBC define additional support for binding by name. I followed the c

Re: [hibernate-dev] Pull request

There are 100, but that's because some of them are for 4.x or 5.0, 5.1 or they lack Tets Cases or the user hasn't confirmed the CLA. We integrate most Pull Requests in a timely fashion. Vlad On Wed, Jun 7, 2017 at 6:08 PM, Sanne Grinovero wrote: > On 7 June 2017 at 15:46, Vlad Mihalcea wrote:

Re: [hibernate-dev] @org.hibernate.annotations.Index and NullPointerException in IndexOrUniqueKeySecondPass

Here you can find more info and some maybe helpful links : https://github.com/hibernate/hibernate-orm/blob/master/CONTRIBUTING.md On Wed, Jun 7, 2017 at 11:04 AM Steve Ebersole wrote: > IMO this is a bug. Even if it is deprecated, the thing should still work > to the extent possible until remov

Re: [hibernate-dev] @org.hibernate.annotations.Index and NullPointerException in IndexOrUniqueKeySecondPass

IMO this is a bug. Even if it is deprecated, the thing should still work to the extent possible until removed. If you have not already, please create a bug report @ https://hibernate.atlassian.net And since you already have a proposed fix, creating a GitHub Pull Request from it would help get it

[hibernate-dev] Upgrade version of Hibernate - default_schema specificity

Hello, For the need of our project we had to upgrade the version of Hibernate from 5.1.2.Final to 5.2.10.Final. We referred to the changelog to adapt our code and it worked perfectly well except that Hibernate couldn't find our schema event though it was declared on the search_path of our Postg

Re: [hibernate-dev] SqlTypeDescriptor bind by name limitation

If I remember correctly there are two other types that are missing a set by name function in the standard API. Also if the type contributor I proposed in PR #1499 is not going to make it in, should I just close it and release it stand-alone? I think there might be an optimization or two that I hav

Re: [hibernate-dev] SqlTypeDescriptor bind by name limitation

I'm not sure what you mean when you say that SqlTypeDescriptor only supports binding by name. On both 5.2 and 6.0 I see : /** * Bind a value to a prepared statement. * * @param st The prepared statement to which to bind the value. * @param value The value to bind. * @param index The position

Re: [hibernate-dev] SqlTypeDescriptor bind by name limitation

Ignoring some poor wording in the Javadocs by me :) On Wed, Jun 7, 2017 at 10:38 AM Steve Ebersole wrote: > I'm not sure what you mean when you say that SqlTypeDescriptor only > supports binding by name. On both 5.2 and 6.0 I see : > > /** > * Bind a value to a prepared statement. > * > * @p

Re: [hibernate-dev] Pull request

On 7 June 2017 at 15:46, Vlad Mihalcea wrote: > Hi Sanne, > > The PR queue has not been neglected at all. The problem was that the issue > was still marked with the "Requires Changes" label, and I assumed it was not > done yet. Great to hear. Sorry, I just assumed it was the case as you've all be

Re: [hibernate-dev] Pull request

Hi Sanne, The PR queue has not been neglected at all. The problem was that the issue was still marked with the "Requires Changes" label, and I assumed it was not done yet. Vlad On Wed, Jun 7, 2017 at 12:41 PM, Sanne Grinovero wrote: > Hi Milo, > > apologies for that. The ORM team had some meet

Re: [hibernate-dev] Let's avoid @hsearch.experimental javadoc tags in SPI

> Gunnar had a POC to create some great reports about private types > leaking on public API.. that's something useful and possibly even ok > to fail the build if that's violated - just we can't do it now as it > would fail the build on our current API :) I was waiting for 6 to > enable that, but ma

Re: [hibernate-dev] Let's avoid @hsearch.experimental javadoc tags in SPI

> Anyway, if you agree with that, I can have a look at the tooling we may > use. I suspect other Hibernate projects may already have such tooling in > place (Hibernate Validator in particular). Indeed we're using some tooling related to this, japicmp: https://github.com/siom79/japicmp And ou

Re: [hibernate-dev] @org.hibernate.annotations.Index and NullPointerException in IndexOrUniqueKeySecondPass

Hi, You should try it with JPA @Index as well, and try to replicate it with one of our test cases: http://in.relation.to/2016/01/14/hibernate-jpa-test-case-template/ If it replicates, you should open a Jira issue along with your PR. Thanks, Vlad On Wed, Jun 7, 2017 at 11:33 AM, Laurent Almeras

Re: [hibernate-dev] Pull request

Vlad / Milo - I've got it on my todo list for today unless Vlad beats me to it :). Chris On 06/07/2017 12:09 AM, Vlad Mihalcea wrote: > Hi, > > If Chris is busy, I can review it for you. > > Vlad > > On Tue, Jun 6, 2017 at 10:36 PM, Milo van der Zee > wrote: > > H

Re: [hibernate-dev] Pull request

Hi Milo, apologies for that. The ORM team had some meetings, travelling, etc.. I guess the PR queue has been temporarily neglected and they'll have to catch up. I don't think you missed something, good idea to call for attention on the mailing list. Thanks, Sanne On 6 June 2017 at 20:36, Milo

Re: [hibernate-dev] Let's avoid @hsearch.experimental javadoc tags in SPI

On 7 June 2017 at 09:19, Yoann Rodiere wrote: > Hi, > > Answers below. > > Yoann Rodière > Hibernate NoORM Team > yo...@hibernate.org > > On 6 June 2017 at 18:48, Sanne Grinovero wrote: >> >> == SPI have very long guarantees, anyway >> >> Considering that an SPI contract has relatively low SLAs I

[hibernate-dev] SqlTypeDescriptor bind by name limitation

Hi, While writing an example for a custom Hibernate Type which supports PostgreSQL arrays, I realized that the SqlTypeDescriptor only supports bind by name: @Override protected void doBind(CallableStatement st, X value, String name, WrapperOptions options) throws SQLException { } However

[hibernate-dev] @org.hibernate.annotations.Index and NullPointerException in IndexOrUniqueKeySecondPass

Hello, I encounter a NullPointerException in IndexOrUniqueKeySecondPass with Hibernate 5.2.10.Final (stack at the end of mail). It appears that problem seems to be linked to @org.hibernate.annotations.Index (deprecated annotation) used in an embeddable component, due to the following code that

Re: [hibernate-dev] Let's avoid @hsearch.experimental javadoc tags in SPI

Hi, Answers below. Yoann Rodière Hibernate NoORM Team yo...@hibernate.org On 6 June 2017 at 18:48, Sanne Grinovero wrote: > == SPI have very long guarantees, anyway > > Considering that an SPI contract has relatively low SLAs I'd like to > be way more "aggressive" in the removal of "this is ex

Re: [hibernate-dev] Pull request

Hi, If Chris is busy, I can review it for you. Vlad On Tue, Jun 6, 2017 at 10:36 PM, Milo van der Zee wrote: > Hello, > > I submitted a pull request and fixed some issues with it (jUnit test and > formatting) and after that nothing happens. How does this work? Do I > just have to be patient or