Re: [hibernate-dev] 6.0 - Proposed org.hibernate.mapping changes

2017-03-22 Thread Steve Ebersole
Coming back to this to see if people see this as an API concern, of if we should define this as an SPI. One potential argument for making it an API is that it is *conceivable* that this model could potentially be walked by the same visitors as described in another thread regarding "model navigatio

Re: [hibernate-dev] Integrating SQLite dialect

2017-03-22 Thread Steve Ebersole
As long as someone agrees to maintain it long term, it is fine to integrate it. Not to be heavy handed, but we might (and sometimes have) drop them later if there is not support from that maintainer and no one else from the community. On Wed, Mar 22, 2017 at 10:42 AM Vlad Mihalcea wrote: > Hi S

Re: [hibernate-dev] Integrating SQLite dialect

2017-03-22 Thread Vlad Mihalcea
Hi Steve, I asked Gwenn about the maintenance issue on the GH issue: https://github.com/hibernate/hibernate-orm/pull/1323 If he agrees to further contribute the SQLite Dialect, we should integrate it. I hope he agrees as well. Vlad On Wed, Mar 22, 2017 at 5:28 PM, Steve Ebersole wrote: > The

Re: [hibernate-dev] Integrating SQLite dialect

2017-03-22 Thread Steve Ebersole
The question is always: who will maintain it? On Wed, Mar 22, 2017 at 10:14 AM Vlad Mihalcea wrote: > Hi, > > After reading this GitHub comment issue comment: > > https://github.com/hibernate/hibernate-orm/pull/1323#issuecomment-288402295 > > I think there is a demand to support it natively, so

[hibernate-dev] Integrating SQLite dialect

2017-03-22 Thread Vlad Mihalcea
Hi, After reading this GitHub comment issue comment: https://github.com/hibernate/hibernate-orm/pull/1323#issuecomment-288402295 I think there is a demand to support it natively, so I'm for integrating the SQLite dialect: https://hibernate.atlassian.net/browse/HHH-10668 Does anyone have any re

Re: [hibernate-dev] org.hibernate.cfg.PropertyContainer support for different property ordering

2017-03-22 Thread Vlad Mihalcea
Ok. I'll close the issue today. On Wed, Mar 22, 2017 at 12:22 AM, Steve Ebersole wrote: > As Chris eloquently stated on the PR I also have a hard time validating > why this change is necessary. > > Also, realize that this contract is going to be (already locally) > superseded in 6.0. > > > > On