Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Steve Ebersole
Currently we make a distinction between FlushMode and `shouldFlushBeforeCompletion`. Is there any reason for that? I have no idea why we decided not to have FlushMode drive `shouldFlushBeforeCompletion`. Anyone? On Mon, Apr 25, 2016 at 10:36 AM Sanne Grinovero wrote: > On 25 April 2016 at 16

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Sanne Grinovero
On 25 April 2016 at 16:28, Steve Ebersole wrote: > I agree with that to an extent. However there is also a balance - clearly > any added complexity has a direct correlation to likelihood of errors/bugs. > We just have to find that balance :) Of course :) Just pointing this out as there was menti

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Steve Ebersole
I'd add this as well... I believe that in most of the cases here we are talking about (passing in a bad query, closing a closed Session, etc) these exceptions are of the "checked" sort, meaning they are easily identifiable prior to deployment. Which IMO helps mitigate somewhat the difficulty handl

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Steve Ebersole
I agree with that to an extent. However there is also a balance - clearly any added complexity has a direct correlation to likelihood of errors/bugs. We just have to find that balance :) On Mon, Apr 25, 2016 at 9:52 AM Sanne Grinovero wrote: > N.B. that chancing the exception types thrown by o

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Sanne Grinovero
N.B. that chancing the exception types thrown by our native methods is an API change in my opinion. So while I think you can have some Hibernate exceptions now extend some of the types expected by JPA, a fully "clean room" approach is not something I'd do in a minor release. On 25 April 2016 at 1

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Steve Ebersole
I agree with Gunnar in that the underlying question here is in how we see the "Hibernate API" long term. However I would consider the following categories: 1. Methods which are Hibernate-only 2. Methods which Hibernate had historically which share a signature with JPA 3. Methods whic

Re: [hibernate-dev] GSoC 2016: Congratulations, your proposal with JBoss Community has been accepted!

2016-04-25 Thread Vlad Mihalcea
Hi Mincong, Welcome and enjoy the GSoC! Vlad On Mon, Apr 25, 2016 at 10:07 AM, Mincong Huang wrote: > Hi Gunnar, > > Thanks you and everybody in hibernate-dev. So glad to join you :) > > Before the action begins, here're some progress I've done in these weeks : > >- Built a simple Apache L

Re: [hibernate-dev] [HSEARCH] Usage of ShardIdentifierProvider

2016-04-25 Thread Sanne Grinovero
On 24 April 2016 at 19:00, Gunnar Morling wrote: > > > 2016-04-22 12:55 GMT+02:00 Sanne Grinovero : >> >> On 21 April 2016 at 18:35, Gunnar Morling wrote: >> > Hi, >> > >> > As IndexShardingStrategy is deprecated, I thought I'd use >> > ShardIdentifierProvider and friends in new code I write. It'

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Sanne Grinovero
Gunnar's words seem wise to me: users will need to have the JPA API on classpath anyway, so I don't see why we should have - and maintain - strategies for different kind of exceptions. This might have been useful in the past, but looking forward? If the reasoning is that Hibernate - having more f

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread Gunnar Morling
The strategy approach sounds nice on first thought, but it also adds complexity. I think the underlying question is: What's the long-term strategy around the "Classic API"? Should it remain in place for all times as a complete alternative to the JPA API? Or should we begin to deprecate it and nar

Re: [hibernate-dev] Various expectation changes in hibernate-core after consolidating hibernate-entitymanager

2016-04-25 Thread andrea boriero
Having a Strategy gives us more flexibility so +1. About the expectations I think what Vlad says is reasonable. On 25 April 2016 at 06:04, Vlad Mihalcea wrote: > Your second email summarizes my thoughts as well. If we can separate the > exception handling in two separate strategies that are de

[hibernate-dev] HipChat history is limited

2016-04-25 Thread Gunnar Morling
Hey all, I was looking for a discussion I had with Emmanuel a few month ago on HipChat. But navigating back in time, I could not go before Feb 1st because I hit "You've reached the end of your viewable chat history. Switch to HipChat Plus for unlimited access". Does anyone know whether we can get

Re: [hibernate-dev] GSoC 2016: Congratulations, your proposal with JBoss Community has been accepted!

2016-04-25 Thread Martin Braun
Hi Mincong, welcome to the team :) Martin -Original Message- From: Mincong Huang To: Gunnar Morling Cc: Hibernate.org Sent: Mon, Apr 25, 2016 9:08 am Subject: Re: [hibernate-dev] GSoC 2016: Congratulations, your proposal with JBoss Community has been accepted! Hi Gunnar,Thanks y

Re: [hibernate-dev] GSoC 2016: Congratulations, your proposal with JBoss Community has been accepted!

2016-04-25 Thread Mincong Huang
Hi Gunnar, Thanks you and everybody in hibernate-dev. So glad to join you :) Before the action begins, here're some progress I've done in these weeks : - Built a simple Apache Lucene example to understand how index and search works - Built a simple Hibernate Search example to understand