Re: [hibernate-dev] Regarding new Dialects

2016-04-18 Thread Brett Meyer
Hey Vlad, our approach had been to accept new Dialects only if: 1. Someone or some entity is willing to develop it 2. Someone or some entity is willing to maintain it *long term* 3. The community demands it (either through the ML, JIRA votes, noise on the forums or externally, etc.) Too of

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Steve Ebersole
I tend to agree with Gail in regards to ORM. Even if it is just fixing a small typo, just use the original Jira key that introduced the typo IMO On Mon, Apr 18, 2016 at 12:38 PM Gail Badner wrote: > I have no problem if you want to do this for non-ORM; however, I've seen > bugs get introduced b

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Gail Badner
I have no problem if you want to do this for non-ORM; however, I've seen bugs get introduced by "clean up" commits in ORM. Fixing these regressions are easier to find and track if there is a "clean up" jira. On Mon, Apr 18, 2016 at 5:54 AM, Vlad Mihalcea wrote: > +1 > > Vlad > > On Mon, Apr 18,

Re: [hibernate-dev] [HSEARCH] Scope of the first version with ES support

2016-04-18 Thread Sanne Grinovero
Hi, thanks for starting this discussion: agreed on the need to release something soon! One word of caution though: it looks like media are picking up on this work with interest so I expect a good amount of people to try the first "preview" out; yet the expectations will probably be higher than usu

Re: [hibernate-dev] http://www.hibernatespatial.org/

2016-04-18 Thread Vlad Mihalcea
I'm going to integrate it in master, 5.1, and 5.0 since theHibernate Spatial module is the same for all three, right? Vlad On Mon, Apr 18, 2016 at 6:19 PM, Steve Ebersole wrote: > The User Guide will definitely need some updates for 5.2, but none of my > changed so far have touched User Guide s

Re: [hibernate-dev] http://www.hibernatespatial.org/

2016-04-18 Thread Karel Maesen
That is correct. Karel On Mon, Apr 18, 2016 at 5:40 PM, Vlad Mihalcea wrote: > I'm going to integrate it in master, 5.1, and 5.0 since theHibernate > Spatial module is the same for all three, right? > > Vlad > > On Mon, Apr 18, 2016 at 6:19 PM, Steve Ebersole > wrote: > > > The User Guide will

Re: [hibernate-dev] What's the identity of Hibernate OGM's "public API" module?

2016-04-18 Thread Sanne Grinovero
I think there was some confusion in this thread, probably it wasn't clear that WildFly 10 already does inject automatically OGM, and that ship sailed so we have to keep in mind what Jipijapa is going to do by default: The current state in WildFly 10's deployers is very simple: if it "sees" that th

Re: [hibernate-dev] http://www.hibernatespatial.org/

2016-04-18 Thread Steve Ebersole
The User Guide will definitely need some updates for 5.2, but none of my changed so far have touched User Guide sources. On Mon, Apr 18, 2016 at 5:25 AM Sanne Grinovero wrote: > On 17 April 2016 at 19:43, Vlad Mihalcea wrote: > > Hi, > > > > Thanks for the update. I'm going to integrate it next

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Vlad Mihalcea
+1 Vlad On Mon, Apr 18, 2016 at 3:48 PM, Guillaume Smet wrote: > OK for me too. That's what I was told when I asked the question a while ago > :). > > On Mon, Apr 18, 2016 at 2:15 PM, Sanne Grinovero > wrote: > > > This question came up again on github; seems Gunnar, Davide and myself > > woul

Re: [hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Guillaume Smet
OK for me too. That's what I was told when I asked the question a while ago :). On Mon, Apr 18, 2016 at 2:15 PM, Sanne Grinovero wrote: > This question came up again on github; seems Gunnar, Davide and myself > would agree on preferring a little more flexibility on the no-orm > projects than ORM

[hibernate-dev] To require or not to require a JIRA for a small-typo kind of commit

2016-04-18 Thread Sanne Grinovero
This question came up again on github; seems Gunnar, Davide and myself would agree on preferring a little more flexibility on the no-orm projects than ORM's guidelines: - https://github.com/hibernate/hibernate-search/pull/1064#issuecomment-211320931 This flexibility would be a perk for regular

Re: [hibernate-dev] http://www.hibernatespatial.org/

2016-04-18 Thread Sanne Grinovero
On 17 April 2016 at 19:43, Vlad Mihalcea wrote: > Hi, > > Thanks for the update. I'm going to integrate it next week after the > Session->EntityFactory merge. Best to double-check with Steve, but I believe updates to the user guide might not need to wait for his refactoring work to be completed?

Re: [hibernate-dev] A warmup task: HSEARCH-2207

2016-04-18 Thread Mincong Huang
The test result looks good :) On Mon, Apr 18, 2016 at 11:09 AM, Gunnar Morling wrote: > Thanks, that's very nice. Going to look into it soon! > > 2016-04-18 11:05 GMT+02:00 Mincong Huang : > >> Hi Sanne and Gunnar, >> >> I've made my first pull request to Hibernate Search : >> https://github.com

Re: [hibernate-dev] A warmup task: HSEARCH-2207

2016-04-18 Thread Gunnar Morling
Thanks, that's very nice. Going to look into it soon! 2016-04-18 11:05 GMT+02:00 Mincong Huang : > Hi Sanne and Gunnar, > > I've made my first pull request to Hibernate Search : > https://github.com/hibernate/hibernate-search/pull/1065 > > Cheers, > Mincong > > On Sun, Apr 17, 2016 at 12:35 AM, M

Re: [hibernate-dev] A warmup task: HSEARCH-2207

2016-04-18 Thread Mincong Huang
Hi Sanne and Gunnar, I've made my first pull request to Hibernate Search : https://github.com/hibernate/hibernate-search/pull/1065 Cheers, Mincong On Sun, Apr 17, 2016 at 12:35 AM, Mincong Huang wrote: > Hi Sanne and Gunnar, > > I've read some docs and understand better about Apache Lucene and