Re: [hibernate-dev] Master

2016-04-06 Thread Chris Cranford
I have to concur with Sanne, a hold on master pushes until this merge of artifacts is complete makes the most sense from an all around logistics perspective. On Wed, Apr 6, 2016 at 4:04 PM, Sanne Grinovero wrote: > Sounds reasonable. Do you think it will be unstable, i.e. should we > temporarily

Re: [hibernate-dev] Hibernate-ORM

2016-04-06 Thread Noel Diaz
Hi Gail,Because this is a blocker for me is there an ETA or a patch that I can pull to move on my end util 5.1.1 actually gets it? Sorry for the annoyance, ~Noel  On Wednesday, March 30, 2016 3:12 PM, Noel Diaz wrote: Hi Gail, Thank you very much for your prompt reply. The reason I aske

Re: [hibernate-dev] Master

2016-04-06 Thread Sanne Grinovero
Sounds reasonable. Do you think it will be unstable, i.e. should we temporarily disable complaint emails from Jenkins, or even the full build tasks? Also, this implies that any future backport becomes similarly harder, so you could also simply ask others to hold pushing on master, then have people

Re: [hibernate-dev] JDBC uses ON_CLOSE connection release mode

2016-04-06 Thread Gail Badner
Sorry, too late; it's gone. I guess I'll wait to hear if people are upset. On Tue, Apr 5, 2016 at 8:51 PM, Vlad Mihalcea wrote: > Hi Gail, > > I'm glad you like the new User Guide. > > Related to the old one, I think we could leave it hosted on docs.jboss.org > because some users might have book

[hibernate-dev] Master

2016-04-06 Thread Steve Ebersole
Obviously consolidating hibernate-entitymanager into hibernate-core is a fairly big effort. And I am getting concerned about the continuing pushes to master in the meantime, many of which I know touch on code I have changed. My concern is obviously getting done all this refactoring work and then

Re: [hibernate-dev] OGM: convergence for a 5.0.0.Final ?

2016-04-06 Thread Sanne Grinovero
On 6 April 2016 at 14:05, Gunnar Morling wrote: > +1 For doing the Final next week or maybe the one after. We could focus for > one day or two to address the remaining (doc) issues. > > One further thing missing would be the slot rename you recently suggested. > Note that the 4.2 core module would

Re: [hibernate-dev] OGM: convergence for a 5.0.0.Final ?

2016-04-06 Thread Gunnar Morling
+1 For doing the Final next week or maybe the one after. We could focus for one day or two to address the remaining (doc) issues. One further thing missing would be the slot rename you recently suggested. Note that the 4.2 core module would be added implicitly if the 4.2 module sets (using slot "m

Re: [hibernate-dev] ReadWrite 2LC "read uncommitted" data anomaly

2016-04-06 Thread Vlad Mihalcea
Hi Radim, I'll have to port the CorrectnessTesCase to EhCache too. The Refresh test case uses H2 explicitly because I wanted to make sure that we always run this test on an MVCC DB (the test sets the MVCC flag in the connection URL). If the underlying DB uses 2PL, the test will halt. The test can

Re: [hibernate-dev] ReadWrite 2LC "read uncommitted" data anomaly

2016-04-06 Thread Radim Vansa
Hi Vlad, I think that this change is safe (it uses only the supported flow of 2LC SPI calls), though it introduces a bit more overhead for the refresh. FYI, besides unit tests, there's CorrectnessTestCase [1] - I've used this one to find out most of flaws in Infinispan 2LC impl. Could be worth

[hibernate-dev] OGM: convergence for a 5.0.0.Final ?

2016-04-06 Thread Sanne Grinovero
Hi, I was hoping that even w/o a specific OGM sprint we would soon (next week?) be able to re-spin the CR1 with minor effort as the 5.0.0.Final. Among tasks scheduled for 5.0.0.Final: - https://hibernate.atlassian.net/issues/?jql=project%20%3D%20OGM%20AND%20fixVersion%20%3D%205.0.0.Final%20ORDER

Re: [hibernate-dev] ReadWrite 2LC "read uncommitted" data anomaly

2016-04-06 Thread Radim Vansa
On 04/06/2016 11:58 AM, Radim Vansa wrote: > On 04/05/2016 04:13 PM, Vlad Mihalcea wrote: >> Hi, >> >> I'd definitely fix it for the refresh operation, which does an implicit >> cache eviction too. >> In this case, the proposed PR solution is fine since it simply locks the >> entry right after it i

Re: [hibernate-dev] ReadWrite 2LC "read uncommitted" data anomaly

2016-04-06 Thread Vlad Mihalcea
Hi Radim, I pushed this fix on master and 5.1, and I managed to add an EHCache where the same behavior was replicated as well: https://github.com/hibernate/hibernate-orm/commit/cbdab9d87f05b4255c7930a32fe995f87f0f3e0b For Infinispan, I think it's better if you can investigate if this is an issue

Re: [hibernate-dev] ReadWrite 2LC "read uncommitted" data anomaly

2016-04-06 Thread Radim Vansa
On 04/05/2016 04:13 PM, Vlad Mihalcea wrote: > Hi, > > I'd definitely fix it for the refresh operation, which does an implicit > cache eviction too. > In this case, the proposed PR solution is fine since it simply locks the > entry right after it is evicted from the cache and releases the lock afte