The original message was received at Fri, 11 Mar 2016 14:06:24 +0800
from lists.jboss.org [101.45.215.108]
- The following addresses had permanent fatal errors -
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss
As I mentioned before, it is not acceptable for the comparator for
PrimitiveByteArrayTypeDescripter to be IncomparableComparator because a
version attribute can be of type byte[]. We definitely do not want all
byte[] version values to compare as equal. A Comparator needs to be
implemented at least
Personally I think using IncomparableComparator or null here makes the most
sense. I'm not really sure what the sort ordering of a byte array would
"mean".
On Thu, Mar 10, 2016, 1:41 AM Gail Badner wrote:
> I've created a pull request implements option A) (creates comparators
> for PrimitiveByt
Done. I updated the pull request to have the "/" check first:
https://github.com/hibernate/hibernate-orm/pull/1295
Vlad
On Thu, Mar 10, 2016 at 2:18 PM, Steve Ebersole wrote:
> I dislike having to instantiate File just to check. Please leave the
> pre-emptive "/" check before instantiating th
I dislike having to instantiate File just to check. Please leave the
pre-emptive "/" check before instantiating the File.
On Thu, Mar 10, 2016 at 4:16 AM Emmanuel Bernard
wrote:
> Right exactly. We ended up requiring persistence.xml and realized that
> not having a specific extension was not
Right exactly. We ended up requiring persistence.xml and realized that
not having a specific extension was not hurting performance and
feasibility.
On Wed 2016-03-09 22:49, Steve Ebersole wrote:
> A PAR is just an archive with a META-INF/persistence.xml file in it. The
> JPA spec does cover this.
I would go for the conservative side. This code was very tedious to
stabilize on all crazy types of URL one can receive (http, file on
various OSes, osgi, custom container url schemes, etc.).
On Thu 2016-03-10 9:52, Vlad Mihalcea wrote:
> The fix goes like this:
>
> if ( filePart.startsWith( "/"
