Re: [hibernate-dev] PK columns and nullability

2015-09-15 Thread Sanne Grinovero
On 15 September 2015 at 19:00, andrea boriero wrote: > since Hibernate makes this assumption I think it's fine to enforce that. +1 > > On 15 September 2015 at 17:36, Steve Ebersole wrote: > >> We have a Pull Request[1] to add a feature to allows Dialects to enforce >> that all columns making up

Re: [hibernate-dev] ORM5 and naming strategies (or get me my foreign keys back!)

2015-09-15 Thread Guillaume Smet
Hi Steve, On Tue, Sep 15, 2015 at 6:49 PM, Steve Ebersole wrote: > The naming strategies are giving me a hard time: we used the >> DefaultComponentSafeNamingStrategy before and there is no real equivalent >> in ORM 5. >> > > org.hibernate.boot.model.naming.ImplicitNamingStrategyComponentPathImpl

Re: [hibernate-dev] PK columns and nullability

2015-09-15 Thread andrea boriero
since Hibernate makes this assumption I think it's fine to enforce that. On 15 September 2015 at 17:36, Steve Ebersole wrote: > We have a Pull Request[1] to add a feature to allows Dialects to enforce > that all columns making up a primary key are defined as non-nullable. > Specifically, apparen

Re: [hibernate-dev] ORM5 and naming strategies (or get me my foreign keys back!)

2015-09-15 Thread Steve Ebersole
> > The naming strategies are giving me a hard time: we used the > DefaultComponentSafeNamingStrategy before and there is no real equivalent > in ORM 5. > org.hibernate.boot.model.naming.ImplicitNamingStrategyComponentPathImpl is the corolary. These may or may not migrate directly due to the *spl

[hibernate-dev] PK columns and nullability

2015-09-15 Thread Steve Ebersole
We have a Pull Request[1] to add a feature to allows Dialects to enforce that all columns making up a primary key are defined as non-nullable. Specifically, apparently Teradata will barf if the PK is defined over columns that are nullable. The PR focuses on exporting the table/pk. However, Hibern

[hibernate-dev] ORM5 and naming strategies (or get me my foreign keys back!)

2015-09-15 Thread Guillaume Smet
Hi all, (starting with kudos to Steve for the 5 release, it's the first problem I find in my migration journey) I'm currently working on porting 2 of our existing applications to ORM 5 (I already ported our template application to start new projects). The naming strategies are giving me a hard t

Re: [hibernate-dev] HHH-3555

2015-09-15 Thread Adam Warski
Hello, thanks a lot for taking the time to migrate that PR! I’m really out-of-touch with the current changes in Hibernate, however there are no changes to the existing public interface (only method additions), and if the tests pass, it’s safe to merge. There’s definitely a lot of value in havin