[hibernate-dev] ORM - FindBugs/PMD

2015-05-19 Thread Steve Ebersole
Checkstyle in ORM is now good to go and enforced in the CI jobs. So I started thinking about FindBugs. We do have FindBugs set up. However it is utterly out of control at the moment. Maybe it's just me, but I find FindBugs impossible to configure "well". Granted I have little experience with i

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Steve Ebersole
https://github.com/hibernate/hibernate-ide-codestyles On Tue, May 19, 2015 at 3:41 PM, Sanne Grinovero wrote: > I'd be happy to share my Eclipse templates in the same repository. > AFAIR we had similar problems, I always thought my templates were "the > reference" but then at some point we had m

[hibernate-dev] Hibernate ORM - next steps

2015-05-19 Thread Steve Ebersole
Now that 5.0 is settling down I wanted to start planning where we go from here in terms of feature development and schedule/releases. Here is my high-level list of features/work: * rework SQL generation & HQL parser * change JDBC extraction to work by position, rather than alias (reworking SQL gen

[hibernate-dev] Upgrades for ci.hibernate.org

2015-05-19 Thread Sanne Grinovero
Hi all, the build slaves for ci.hibernate.org got refreshed. Several jobs failed during the last week as the micro quotas we had were getting full. The 4 nodes have now 4 times the RAM, 4 times the CPU and 8 times the disk space. (that's 15GB of RAM, 8 CPUs, 80GB of dedicated space per node) N.B.

Re: [hibernate-dev] Hibernate O/RM Java 8 API.

2015-05-19 Thread Steve Ebersole
On Tue, May 19, 2015 at 12:51 PM, Jakub Narloch wrote: > > > 2015-05-19 18:16 GMT+02:00 Steve Ebersole : >> >> > - Enable registration of LocaleDate, LocalTime as query params. >> >> You can do that now: >> * org.hibernate.Query#setParameter(java.lang.String, java.lang.Object) >> * org.hibernate.

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Sanne Grinovero
I'd be happy to share my Eclipse templates in the same repository. AFAIR we had similar problems, I always thought my templates were "the reference" but then at some point we had multiple versions, I suspect because of freshly exporting the same from a newer version of the IDE but we'll never know.

Re: [hibernate-dev] Hibernate O/RM Java 8 API.

2015-05-19 Thread Jakub Narloch
2015-05-19 18:16 GMT+02:00 Steve Ebersole : > Let's keep this on list ok? Thanks. > > First, have you seen the new hibernate-java8 module that is part of 5.0? > Ahh, I somehow miss that, going to take a look right away. > > > > > At the moment I would like to focus on three things: > > - Introdu

Re: [hibernate-dev] Hibernate O/RM Java 8 API.

2015-05-19 Thread Steve Ebersole
Let's keep this on list ok? Thanks. First, have you seen the new hibernate-java8 module that is part of 5.0? Some replies in-line... > But I am curious what would be your opinion on this extended API idea and approach that I took and whether you would for instance consider taking it under the h

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Steve Ebersole
I just did some bulk reformatting to get things conforming with styles. But moving forward I agree that we should not be reformatting entire files. Eclipse used to do that by default (cough cough). And yes I understand that there is another axis for IDEs. I just figured that one was self-evident

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Gunnar Morling
+1 for having the style(s) in Git. There is another axis, though, which is the used IDE. So far we couldn't find a way to make Eclipse and IntelliJ do exactly the same thing wrt. formatting. There is just not the exact same set of options available in both IDEs, so outputs will always differ a bit

Re: [hibernate-dev] Hibernate O/RM Java 8 API.

2015-05-19 Thread Steve Ebersole
Jakub, Thanks for starting on this :) I think the thing that is missing here is the one that most users will want which is support for Optional attributes in their domain model. Of course that is the harder one because it would require changes inside Hibernate. I'll take a look at the code and

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Steve Ebersole
My thinking was more about how to find which one supersedes which others. If I (as a contributor) have a few of these code style files available to me from the Hibernate team, how do I know which is the latest? As I pointed out, I actually had to update my code style slightly after migrating to 14

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread Hardy Ferentschik
Hi, Hibernate Validator used initially the same style as ORM. I am saying used to since the file attached to this url - http://hibernate.org/validator/contribute/ - seems to differ a fair bit from the file you are referring to. A lot of the difference might just be indentation and re-ordering is

Re: [hibernate-dev] Checkstyle and ORM

2015-05-19 Thread Hardy Ferentschik
On Mon, May 18, 2015 at 03:07:08PM -0500, Steve Ebersole wrote: > Hardy, do you happen to still have your sed script for updating these file > headers? I do, they are attached to the JIRA issue - https://hibernate.atlassian.net/browse/HV-926. You will need to adjust them to your needs. I used fin

[hibernate-dev] [ORM|OGM|Search] Adding an unwrap() new method to org.hibernate.Session

2015-05-19 Thread Sanne Grinovero
I was looking at how Search and OGM benefit from the SessionDelegatorBaseImpl; extending this base class was a good progress but there is something missing. OGM has to still reimplement all methods defined by the EventSource contract, making the implementation confusing as while it extends the bas

Re: [hibernate-dev] Sharing IDE code styles

2015-05-19 Thread andrea boriero
I'm using your version On 19 May 2015 at 04:01, Steve Ebersole wrote: > The recent discussion on Checkstyle got me thinking about best ways to > share/distribute code styles for IDE setup. Storing them in the project > itself is not very workable for IntelliJ at least. I started thinking > abo

Re: [hibernate-dev] NoSuchMethodError running hibernate-infinispan tests with Infinispan 7.2.1

2015-05-19 Thread Galder ZamarreƱo
This is not problematic for 2LC users because except in testing, we never check this value in the production code. IOW, in production we set max entries but we don't query it, so it's not problematic. In testing, we verify that the cache's eviction max entries is the one we've configured via the