So here is what I did. I think this is the best compromise, short of us
hand crafting the keywords for each and every one of our Dialects...
1) I added this method to Dialect:
/**
* Hook into auto-quoting of identifiers that are deemed to be keywords.
By default we
* return all of the followi
Hi Sanne,
could you provide me with the exact message it told you?
I am using the Web interface for aol.com so it can't be related
to my email client...
Martin Braun
martinbraun...@aol.com
www.github.com/s4ke
-Original Message-
From: Sanne Grinovero
To: Martin Braun
Cc: Hibernate
Right you could have the Dialects return the standard set by default,
then someone with specialistic knowledge of the specific database
could either override that with a custom Dialect or provide an
improvement patch.
I guess it's wise to not ignore the "extra keywords" defined by the
driver, but
I understand what you are saying, in principle. Then there is the
practical side. Personally I am not so interested in doing all the
investigation over each Dialect to determine their exact set of keywords (A
LOT of work), not to mention typing all that up (A LOT of duplication). Of
course, if s
Hi all,
Hardy completed the Faceting re-work in Hibernate Search to use the
much improved implementation from recent versions of Lucene, and we'd
like to merge his work now making these improvements available to
users of Hibernate Search 5.2.0+
There is a catch: while the API to create a Faceting
Hi Martin,
I would never have seen your email if Emmanuel hadn't replied to it.
Apparently google (I'm using gmail) is flagging your email account as
spam; the error message I see is too short and ambiguous to understand
what's wrong, but it seems like aol.com could not meet their
requirements.
Th
Rather than basing our decisions on standards, wouldn't it be more
useful to base it on *exactly* what the used database requires?
In other words, why wouldn't it suffice to have a single source of
keywords: the Dialect.
--Sanne
On 1 May 2015 at 15:19, Steve Ebersole wrote:
> Interestingly, y
Interestingly, your IRC ping asked about KEY which in fact is *not* a
SQL:2003 keyword. It had been a keyword in 92 and 99 SQL standards, but
was removed in 2003.
Which actually opens up an another interesting discussion as far as how
aggressive to be in terms of affirming an identifier as being
Gail, I saw your ping on IRC and thought it made sense to address here,
since you were not around on IRC anymore.
Overall, starting with 5.0, the idea is for Hibernate to automatically
quote any identifiers is recognizes as a keyword. This is all encapsulated
within the org.hibernate.engine.jdbc.
