TBH, I have no idea what happens to comments on a Pull Request when you
squash and force push.
I'd just leave the multiple commits. We can squash them later.
On Tue, Apr 7, 2015 at 1:59 PM, John O'Hara wrote:
> Steve,
>
> I have made changes based on the github comments and your comments belo
Another change with master is that IntelliJ import finally works as far as
properly setting up excludes in IntelliJ to not "hide" generated-src. The
fact that generated-src is under the $buildDir makes this more complicated
than it need to be, but it works.
There is currently a minor issue with I
Steve,
I have made changes based on the github comments and your comments below
(https://github.com/johnaoahra80/hibernate-orm/commits/HHH-9701).
Do you want me to squash the commits down to one? Not sure how this
would effect the comments you have already made on GH
Thanks
John
On 06/04/15
There will be a different way to do that...
On Apr 7, 2015 10:17 AM, "Gunnar Morling" wrote:
> > 4) Transaction is now a single impl. The distinctions are all handled
> internally. TransactionImplementor is gone too
>
> Can OGM still register a custom TransactionFactory? We'd need that in
> ord
> 4) Transaction is now a single impl. The distinctions are all handled
internally. TransactionImplementor is gone too
Can OGM still register a custom TransactionFactory? We'd need that in order
to return our "NoSQL-local" transaction implementation.
2015-04-07 16:27 GMT+02:00 Steve Ebersole
Ok, not hearing any feedback on this so I will proceed as outlined here.
On Wed, Mar 25, 2015 at 3:15 PM, Steve Ebersole wrote:
> We also identified needs for Status#ROLLING_BACK and Status#COMMITTING, so
> consider those in the enum as well.
>
> On Wed, Mar 25, 2015 at 12:19 PM, Steve Ebersole
Binding on Java 7/8 at runtime should work just fine.
I've sent PR https://github.com/hibernate/hibernate-orm/pull/930 to update
XJC and configure the "target" parameter. I've built that branch with JDK 8
successfully, all tests pass.
I've also checked where the required() attribute actually is u
