Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Hardy Ferentschik
>> So what is your take on this then? Leave as is and keep the fact that the >> default depth value changes its default value depending >> on whether or not includePaths is used? That would be option >> >> #3 Keep status quo for value of depth parameter >> >> I raised the concern that the simp

Re: [hibernate-dev] Pushed 3.18.2-GA release of Javassist...

2014-05-27 Thread Steve Ebersole
I am a little leery considering the issues this seems to cause every time... On Tue, May 27, 2014 at 12:56 PM, Scott Marlow wrote: > FYI, Javassist version 3.18.2-GA is now available. > http://issues.jboss.org/browse/JASSIST/fixforversion/12323811 lists the > four issues resolved. > > Should we

Re: [hibernate-dev] Changing method signatures in micro releases

2014-05-27 Thread Gail Badner
The original bug could have been fixed without changing the SPI, since it only affected OneToManyPersister. Since there was no reason to change the SPI in the first place, I opted to deprecate the new method and keep the old. Thanks for checking it! Gail - Original Message - > From: "Gu

[hibernate-dev] Pushed 3.18.2-GA release of Javassist...

2014-05-27 Thread Scott Marlow
FYI, Javassist version 3.18.2-GA is now available. http://issues.jboss.org/browse/JASSIST/fixforversion/12323811 lists the four issues resolved. Should we upgrade Hibernate ORM master to use Javassist 3.18.2-GA? Scott ___ hibernate-dev mailing list hi

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Emmanuel Bernard
On 27 May 2014, at 12:29, Hardy Ferentschik wrote: > Thanks for the input. Comments inline. > > On 27 Jan 2014, at 12:01, Emmanuel Bernard wrote: > >> >> On 06 May 2014, at 21:43, Hardy Ferentschik wrote: >> >>> Where are we at in this discussion? >>> >>> I think we basically have to main

[hibernate-dev] NoORM meeting

2014-05-27 Thread Emmanuel Bernard
We discussed: - Hibernate Search 5 / Infinispan 7 implications for OGM release wise - The necessary changes from Infinispan to do remote Infinispan support in OGM - the OGM roadmap - Neo4J remaining tasks - PoC for free f-rm entities in Hibernate Search Actions: - gmorling or DavideD to test an

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Emmanuel Bernard
On 29 Apr 2014, at 15:09, Sanne Grinovero wrote: > I'd actually like to propose to change the depth default to zero, and > since includePath also defaults to an empty list, we'd be logging a > warning as the @IndexedEmbedded annotation would have no effect. > > >> I also find it not intuitive

Re: [hibernate-dev] EntityManagerFactoryBuilderImpl constructor is accessing the CDI BeanManager too early (during 1st phase) ...

2014-05-27 Thread Scott Marlow
On 05/23/2014 09:27 AM, Scott Marlow wrote: > On 05/21/2014 03:36 PM, Scott Marlow wrote: >> I started to push on Hibernate master integration for WildFly [1] + >> Jipijapa [2]. >> >> http://pastie.org/9196859 is a NPE that occurs when the CDI BeanManager >> is accessed during the first (EntityMana

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Hardy Ferentschik
Thanks for the input. Comments inline. On 27 Jan 2014, at 12:01, Emmanuel Bernard wrote: > > On 06 May 2014, at 21:43, Hardy Ferentschik wrote: > >> Where are we at in this discussion? >> >> I think we basically have to main proposals. >> >> #1 Don’t include the embedded id per default. If

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Emmanuel Bernard
On 29 Apr 2014, at 20:43, Hardy Ferentschik wrote: > On 29 Jan 2014, at 15:24, Sanne Grinovero wrote: > But this forces you to list all fields to include explicitly in case you want the id added, but otherwise are happy to just use the default @IndexedEmbedded. >>> >>> I think

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-05-27 Thread Emmanuel Bernard
On 06 May 2014, at 21:43, Hardy Ferentschik wrote: > Where are we at in this discussion? > > I think we basically have to main proposals. > > #1 Don’t include the embedded id per default. If @IndexEmbedded is used via > the depth parameter there is no way to include the embedded id. > In