Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Hardy Ferentschik
On 29 Jan 2014, at 15:24, Sanne Grinovero wrote: >>> But this forces you to list all fields to include explicitly in case you >>> want the id added, but otherwise are happy >>> to just use the default @IndexedEmbedded. >> >> I think we should keep the id with the default @IndexedEmbedded. It >

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Hardy Ferentschik
>>> Remember _includePath_ is additive to fields otherwise included via >>> @IndexedEmbedded _depth_, so it fits nicely for this role: >> >> Is that really true? AFAIK the includePath attribute changes the behaviour >> of the depth attribute. >> Depth is ‘0’ per default if ‘includePath’ is used.

Re: [hibernate-dev] GitHub repo for demo projects

2014-04-29 Thread Brett Meyer
While we're on this subject, it's been suggested that having simple quickstart projects for testcase development would be helpful. For example, see https://hibernate.atlassian.net/browse/HHH-9105. Big +1 from me -- it would be great to point JIRA reporters towards the quickstart when asking fo

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Sanne Grinovero
On 29 April 2014 13:49, Guillaume Smet wrote: > Hi, > > On Tue, Apr 29, 2014 at 1:45 PM, Hardy Ferentschik > wrote: >>> Yes I mean we could never include it by default, and allow the >>> "includePath" to be the (only) way to include things. >> >> But this forces you to list all fields to include

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Sanne Grinovero
On 29 April 2014 12:45, Hardy Ferentschik wrote: > Question: would we still interpret the literal "id" as a keyword pointing to whatever getter is the primary key of the embedded object? >>> >>> Why still? We don’t do this at the moment afaict. Our examples and tests >>> just use ‘id’ >

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Guillaume Smet
Hi, On Tue, Apr 29, 2014 at 1:45 PM, Hardy Ferentschik wrote: >> Yes I mean we could never include it by default, and allow the >> "includePath" to be the (only) way to include things. > > But this forces you to list all fields to include explicitly in case you want > the id added, but otherwise

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Hardy Ferentschik
>>> Question: would we still interpret the literal "id" as a keyword >>> pointing to whatever getter is the primary key of the embedded object? >> >> Why still? We don’t do this at the moment afaict. Our examples and tests >> just use ‘id’ >> all the time. > > Right I got confused. I thought fo

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Sanne Grinovero
On 29 April 2014 11:28, Hardy Ferentschik wrote: > > On 29 Jan 2014, at 00:14, Sanne Grinovero wrote: > >> I'd avoid a new configuration element. > > +1 Sure, that would be best. > >> I think we should strive at keeping the index small by default unless >> there is a strong usability penalty, and

Re: [hibernate-dev] [Search] Index embedded and id property of embedded entity

2014-04-29 Thread Hardy Ferentschik
On 29 Jan 2014, at 00:14, Sanne Grinovero wrote: > I'd avoid a new configuration element. +1 Sure, that would be best. > I think we should strive at keeping the index small by default unless > there is a strong usability penalty, and I don't think this is a big > one. I agree. I don’t think t

Re: [hibernate-dev] GitHub repo for demo projects

2014-04-29 Thread Gunnar Morling
2014-04-29 11:19 GMT+02:00 Sanne Grinovero : > Created https://github.com/hibernate/hibernate-demos Cool, thanks. License: I've picked ASL2.. I guess that's ok for all our demos? > That seems reasonable to me. > > On 29 April 2014 07:00, Gunnar Morling wrote: > > 2014-04-29 7:58 GMT+02:00 G

Re: [hibernate-dev] GitHub repo for demo projects

2014-04-29 Thread Sanne Grinovero
Created https://github.com/hibernate/hibernate-demos License: I've picked ASL2.. I guess that's ok for all our demos? On 29 April 2014 07:00, Gunnar Morling wrote: > 2014-04-29 7:58 GMT+02:00 Gunnar Morling : > >> 2014-04-29 0:21 GMT+02:00 Sanne Grinovero : >> >>> Nice idea! >>> we could have ea