Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Emmanuel Bernard
I don't ahve much to say besides what has been said on this thread already. The "tolerated" feature works in less cases than I anticipated as Guillaume demonstrated. The different with the new patch is that it happens systematically (on criteria restrictions) and leads to a lot of unitary entity lo

Re: [hibernate-dev] [AND] Search: changing the way we search

2014-03-21 Thread Emmanuel Bernard
On Thu 2014-03-20 18:50, Guillaume Smet wrote: > On Thu, Mar 20, 2014 at 3:08 PM, Emmanuel Bernard > wrote: > > I tend to disagree with you. The SimpleQueryBuilder seems to disagree > > with you too as SHOULD is the default. Care to give your arguments in > > favor of a different value for the def

Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Hardy Ferentschik
On 21 Jan 2014, at 13:41, Sanne Grinovero wrote: > The question of being able to filter via Criteria or Hibernate Session > Filters is a recurring feature request so we need to be cautious here. The question is can we support it properly (most notably correctly). > You make good points, and if

Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Sanne Grinovero
The question of being able to filter via Criteria or Hibernate Session Filters is a recurring feature request so we need to be cautious here. You make good points, and if it comes to a choice of support either/or we'll certainly drop the Criteria filtering as obviously we won't make concessions on

Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Guillaume Smet
Hi Hardy, On Fri, Mar 21, 2014 at 12:14 PM, Hardy Ferentschik wrote: > I am even wondering whether we should not go a step further and disallow > the use of Criterias altogether in FullTextSessionImpl by throwing an > exception > in case of its use. We then can add an explicit method to FullText

Re: [hibernate-dev] jsr107

2014-03-21 Thread Steve Ebersole
Thanks for looking into this Alex. Like Emmanuel, I'd assume providers would want to leverage any advantages they see in their native APIs, but a 107-based cache implementation would certainly be useful. On Thu, Mar 20, 2014 at 9:28 AM, Alex Snaps wrote: > Started yesterday night actually...

Re: [hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Hardy Ferentschik
Hi Guillaume, nice job with this issue. I was about to comment on the pull request, but now I do it here. On 21 Jan 2014, at 11:10, Guillaume Smet wrote: > So, my patch here [1] broke a test which checks that Criteria + > restrictions mostly work - even if it's documented as not supported > an

[hibernate-dev] [Search] The case against searching with Criteria + restrictions

2014-03-21 Thread Guillaume Smet
Hi, = Context = So, my patch here [1] broke a test which checks that Criteria + restrictions mostly work - even if it's documented as not supported and not working. "Mostly" as in "you can't get the result size but you might get the results". See [2] for explanations. I spent some time yesterda