Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Steve Ebersole
Also, unless we have some normalization rules, my point was that we literally cannot do this today in annotations. Essentially the bug-a-boo is composites (and maybe collections as composite via allowance of "map.", etc). We'd essentially have to normalize all paths for converters to be the co

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Steve Ebersole
The point is that, for converter, sometimes "the XML winning" isn't "the XML winning". What I mean is that just like with @Convert, can exist at the or level. So given your example: @Entity public class Sub { ... @Convert( converter=Converter1.class ) public String getIt() {

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Emmanuel Bernard
Yes I get that but JPAOverriddenAnnotationReader is only about reading the XML and converting it into annotations. I understand that implementing the rules based on the annotations is more complex than annotation override. On Fri 2013-08-30 8:44, Steve Ebersole wrote: > Its not that easy. This

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Steve Ebersole
Its not that easy. This is not as simple as AttributeOverride. The rules here are much more complex (or convoluted, depending on your perspective). An AttributeOverride always overrides. The is just not the case here with converters. Plus how AttributeOverride works does not need to vary f

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Emmanuel Bernard
On Fri 2013-08-30 6:27, Steve Ebersole wrote: > > On Fri 30 Aug 2013 06:05:37 AM CDT, Emmanuel Bernard wrote: > >> > >> > >>2) The 'declaringClassName' passed in to SimpleValueBinder#setType > >>is Sub. So maybe we can leverage that. But > >>org.hibernate.cfg.annotations.PropertyBinder#makeProper

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Steve Ebersole
On Fri 30 Aug 2013 06:05:37 AM CDT, Emmanuel Bernard wrote: >> >> >> 2) The 'declaringClassName' passed in to SimpleValueBinder#setType >> is Sub. So maybe we can leverage that. But >> org.hibernate.cfg.annotations.PropertyBinder#makePropertyAndValue >> (the main caller of this method) has explici

Re: [hibernate-dev] hiberate-commons-annotations and locating annotations

2013-08-30 Thread Emmanuel Bernard
On Thu 2013-08-29 16:16, Steve Ebersole wrote: > Ok, so given the initial Super/Sub setup, what we get in > SimpleValueBinder#setType is this: > > 1) The XProperty passed in is defined as follows: > a) It is a JavaXProperty speciffically > b) Its 'annotatedElement' attribute (not exposed) is the >