[hibernate-dev] unit test PSA

2013-08-05 Thread Brett Meyer
A friendly PSA regarding unit tests... I spent the afternoon cleaning up tests that were failing in our matrix CI job. There were lots of failures on various DBs due to the following: 1.) Columns referenced by a UK/PK must NOT be nullable. 2.) Tests that solely use ConnectionProviderBuilder in

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 6:45 PM, Sanne Grinovero wrote: > Great, that's https://hibernate.atlassian.net/browse/HSEARCH-1384 > then. Guillaume, is that something you would consider giving a try > yourself? Yep. I'll have a look and see if I can come up with something. I assigned the JIRA issue to

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Hardy Ferentschik
On 5 Jan 2013, at 5:31 PM, Gunnar Morling wrote: > I think I could help with doing with the release, if you, Hardy, don't get to > it (assuming it's a common Maven release process as e.g. in HV). Awesome. Let's sync tomorrow. > Btw. there seems to be an issue with one failing test on master a

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Sanne Grinovero
Great, that's https://hibernate.atlassian.net/browse/HSEARCH-1384 then. Guillaume, is that something you would consider giving a try yourself? Sanne On 5 August 2013 17:39, Guillaume Smet wrote: > On Mon, Aug 5, 2013 at 6:07 PM, Sanne Grinovero wrote: >> So we actually would be better off fixin

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 6:07 PM, Sanne Grinovero wrote: > So we actually would be better off fixing that issue, rather than > polluting the metadata API with hard to explain methods. > > Fixing the issue in its entirety is very complex, but what would you > think of having an option to run the Mass

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Sanne Grinovero
On 5 August 2013 16:57, Guillaume Smet wrote: > On Mon, Aug 5, 2013 at 5:37 PM, Sanne Grinovero wrote: >> I understand my code, but I'm not sure I understood why you would need this? > > Instead of calling the mass indexer directly for all our classes, we > get the root indexed types and we index

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 5:37 PM, Sanne Grinovero wrote: > I understand my code, but I'm not sure I understood why you would need this? Instead of calling the mass indexer directly for all our classes, we get the root indexed types and we index them one by one using the mass indexer. This is the o

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Sanne Grinovero
On 5 August 2013 15:56, Hardy Ferentschik wrote: > > On 5 Jan 2013, at 3:44 PM, Guillaume Smet wrote: > >> (Hardy, sorry for the double post, forgot the list) >> >> On Mon, Aug 5, 2013 at 3:20 PM, Hardy Ferentschik >> wrote: >>> TBH i am not completely sure I understand what the method does. Th

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Gunnar Morling
I think I could help with doing with the release, if you, Hardy, don't get to it (assuming it's a common Maven release process as e.g. in HV). Btw. there seems to be an issue with one failing test on master as per the CI job: http://ci.hibernate.org/job/hibernate-metamodelgen-master/ (I just trigg

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Guillaume Smet
On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik wrote: >> And this one was a work in progress a long time ago and I should >> probably go back to work on it to provide some feedback to Hardy: >> https://hibernate.atlassian.net/browse/METAGEN-85 > > Right, I still have not been able to reproduce

Re: [hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Hardy Ferentschik
On 5 Jan 2013, at 4:02 PM, Guillaume Smet wrote: > It's been a long time since the last release of JPA modelgen and we > fixed a couple of annoying bugs, namely: > https://hibernate.atlassian.net/browse/METAGEN-81 > https://hibernate.atlassian.net/browse/METAGEN-82 +1 We really need to get a re

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Hardy Ferentschik
On 5 Jan 2013, at 3:44 PM, Guillaume Smet wrote: > (Hardy, sorry for the double post, forgot the list) > > On Mon, Aug 5, 2013 at 3:20 PM, Hardy Ferentschik wrote: >> TBH i am not completely sure I understand what the method does. The docs >> says: >> >> "From the set of classes a new set is

[hibernate-dev] Putting a new release of JPA modelgen into shape?

2013-08-05 Thread Guillaume Smet
Hi all, It's been a long time since the last release of JPA modelgen and we fixed a couple of annoying bugs, namely: https://hibernate.atlassian.net/browse/METAGEN-81 https://hibernate.atlassian.net/browse/METAGEN-82 And this one was a work in progress a long time ago and I should probably go bac

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Guillaume Smet
(Hardy, sorry for the double post, forgot the list) On Mon, Aug 5, 2013 at 3:20 PM, Hardy Ferentschik wrote: > TBH i am not completely sure I understand what the method does. The docs says: > > "From the set of classes a new set is built containing all indexed > subclasses, but removing then all

Re: [hibernate-dev] Hibernate Search 4.4.0.Alpha1 release

2013-08-05 Thread Hardy Ferentschik
On 2 Jan 2013, at 9:17 PM, Guillaume Smet wrote: > The SearchFactory.getIndexedTypes API looks nice. Great. > Would it be possible to also expose something like getRootIndexedTypes > based on the magic done in MassIndexerImpl.toRootEntities? TBH i am not completely sure I understand what the