Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Strong Liu
btw, I just installed the checkstyle and findbugs plugin on our CI server :D On Apr 19, 2013, at 12:44 AM, Steve Ebersole wrote: > IDEA has a checkstyle plugin (and a jdepend plugin fwiw). And it will > also immediately show violations in the editor (as well as collect them > in the problems

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Steve Ebersole
IDEA has a checkstyle plugin (and a jdepend plugin fwiw). And it will also immediately show violations in the editor (as well as collect them in the problems window). It does not auto detect the settings however, you need to point it to the file. You can still compile, run tests, etc. Very i

[hibernate-dev] IRC Developer Meeting - 4/18

2013-04-18 Thread Steve Ebersole
Discussed few different topics today: CI builds, EE7/4.3 status and integration with JBoss AS 8, 4.2 release, recent Gradle update and others. [11:27] Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/hibernate-dev/2013/hibernate-dev.2013-04-18-14.59.html [11:27] Minutes (text):

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Hardy Ferentschik
On 18 Jan 2013, at 6:15 PM, Sanne Grinovero wrote: > On 18 April 2013 17:12, Davide D'Alto wrote: >> I don't have any particular objection to set it on the verify phase. I tend >> to always use mvn install anyway. >> >> The argument I can use to promote the compile phase (for sake of discussio

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Sanne Grinovero
On 18 April 2013 17:12, Davide D'Alto wrote: > I don't have any particular objection to set it on the verify phase. I tend > to always use mvn install anyway. > > The argument I can use to promote the compile phase (for sake of discussion > only) > I like the fact that I can check the code writing

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Davide D'Alto
I don't have any particular objection to set it on the verify phase. I tend to always use mvn install anyway. The argument I can use to promote the compile phase (for sake of discussion only) I like the fact that I can check the code writing mvn compile, therefore without starting any test. If you

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Sanne Grinovero
On 18 April 2013 16:56, Gunnar Morling wrote: > Also you're not always in your IDE. For instance I recently tried to change > something experimentally in the AS code base, just using my text editor (no, > it was not vi ;). Then CS can really be in the way for compilation/tests. So > I think it mak

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Gunnar Morling
Also you're not always in your IDE. For instance I recently tried to change something experimentally in the AS code base, just using my text editor (no, it was not vi ;). Then CS can really be in the way for compilation/tests. So I think it makes most sense to have it in the "verify" phase. 2013/

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Hardy Ferentschik
On 18 Jan 2013, at 5:27 PM, Sanne Grinovero wrote: > On 18 April 2013 16:13, Gunnar Morling wrote: >> Yeah, I was just about to suggest that :) > > Good idea, but isn't it true that if your IDE is correctly setup it doesn't > matter? True, but sometimes you might want to ignore the rules.

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Sanne Grinovero
On 18 April 2013 16:13, Gunnar Morling wrote: > Yeah, I was just about to suggest that :) Good idea, but isn't it true that if your IDE is correctly setup it doesn't matter? I'm not sure about IDEA, but Eclipse detects the checkstyle rules and shows violations right away. > 2013/4/18 Hardy Fere

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Gunnar Morling
Yeah, I was just about to suggest that :) 2013/4/18 Hardy Ferentschik > > On 18 Jan 2013, at 4:48 PM, Sanne Grinovero wrote: > > > Hi all, > > > > yesterday we merged checkstyle integration in Hibernate OGM: it's > > going to fail the compile phase if there are violations (!). > > +1 Joining t

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Hardy Ferentschik
On 18 Jan 2013, at 4:48 PM, Sanne Grinovero wrote: > Hi all, > > yesterday we merged checkstyle integration in Hibernate OGM: it's > going to fail the compile phase if there are violations (!). +1 Joining the ranks of Validator and Search :-) Btw, in HV Gunnar convinced me to attache the chec

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Sanne Grinovero
On 18 April 2013 15:51, Steve Ebersole wrote: > Nice! > > Curious how you got checkstyle to validate that tabs are used for indent? Davide created this regex: https://github.com/hibernate/hibernate-ogm/blob/master/src/main/build-config/checkstyle.xml#L36 Sanne > > On Apr 18, 2013 9:49 AM, "San

Re: [hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Steve Ebersole
Nice! Curious how you got checkstyle to validate that tabs are used for indent? On Apr 18, 2013 9:49 AM, "Sanne Grinovero" wrote: > Hi all, > > yesterday we merged checkstyle integration in Hibernate OGM: it's > going to fail the compile phase if there are violations (!). > > By doing so, we als

[hibernate-dev] Checkstyle: enforced!

2013-04-18 Thread Sanne Grinovero
Hi all, yesterday we merged checkstyle integration in Hibernate OGM: it's going to fail the compile phase if there are violations (!). By doing so, we also had to re-style a large portion of code, as surprisingly even though I though we where very careful on style and whitespace inspections, huma

Re: [hibernate-dev] Build and AnnotationProcessors

2013-04-18 Thread Steve Ebersole
1) Making IDE setup simpler does not necessarily mean making the CLI builds more complicated. That is a somewhat obvious statement, but one I think we need to keep in mind here. 2) The AnnotationProcessor question was kind of a separate question. I am curious why you think that combining the

Re: [hibernate-dev] Build and AnnotationProcessors

2013-04-18 Thread Hardy Ferentschik
On 17 Jan 2013, at 9:53 PM, Steve Ebersole wrote: > Personally I find it funny. To me this question of "circularity" is exactly > the same. Works great in the build in any and all ways, but the IDEs have > issue with it to varying degrees. Yet everyone wants to change the > circularity thi

Re: [hibernate-dev] Build and AnnotationProcessors

2013-04-18 Thread Hardy Ferentschik
On 17 Jan 2013, at 9:33 PM, Brett Meyer wrote: > "Get the sources and load it directly in your IDE. IMO that is stupid." > > Honestly, that's always been the absolute *first* thing I do. I'd argue that > most contributing developers are interested in the src, first and foremost. For sure. I