Re: [hibernate-dev] Scanner contract

2013-03-15 Thread Steve Ebersole
Should have mentioned that PersistenceUnitDescriptor[1] is an abstraction I introduced in 4.3 codebase to insulate processing from whether the PU come to use via persistence.xml parsing (SE) or being handed a PersistenceUnitInfo (EE). [1] https://github.com/hibernate/hibernate-orm/blob/master/

[hibernate-dev] Scanner contract

2013-03-15 Thread Steve Ebersole
I am proposing a change to the org.hibernate.jpa.packaging.spi.Scanner SPI. First I suggest we make the scanning happen in one call, and that one call return a token of the result. Currently we have 4 "scan" methods on the Scanner contract; I instead propose there be a ScanResult that holds t

Re: [hibernate-dev] strategies for truncating identifiers

2013-03-15 Thread Steve Ebersole
Not so sure a name class is going to be able to handle this in isolation. This is really why we have the split between logical and physical names. Internally we always unique things based on the logical name. That part works well. In your examples, the logical names would be something like