Re: [hibernate-dev] fix for https://hibernate.onjira.com/browse/HHH-766

2012-12-16 Thread Strong Liu
I did a little more based on your idea, could you give it a try? https://hibernate.onjira.com/browse/HHH-7869 https://github.com/hibernate/hibernate-orm/pull/426 I also have the test result attached to the jira On Dec 17, 2012, at 12:47 PM, Strong Liu wrote: > Stepan, > > thanks for the patch

Re: [hibernate-dev] fix for https://hibernate.onjira.com/browse/HHH-766

2012-12-16 Thread Strong Liu
Stepan, thanks for the patch, though there are some processes we'd like to use: 1. open a jira ( since HHH-766 is closed ) and link it to the original one (HHH-766) 2. give some numbers / tests to show your patch performs better than the old one 3. create a github pull request p.s. from what i

[hibernate-dev] fix for https://hibernate.onjira.com/browse/HHH-766

2012-12-16 Thread Stepan Yakovenko
HI! StringHelper.firstIndexOfChar is extremely inefficient on long strings. It'd scan all string many times even if it starts with stop character. I propose to change it this way: public static int firstIndexOfChar(String sqlString, String string, int startindex) { Set stopchars = new HashSet