Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Steve Ebersole
I dislike static builders. If we were going to go that route, I'd rather see contextual builders: StoredProcedureCall call = session.createStoredProcedureCall("my_proc"); OutParameter p1Param = call.parameterRegistrar().out(Long.class).named("p1"); However, this still assumes that these "specia

Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Gunnar Morling
Right, that's what I had in mind. Another option would be a more builder-like approach: StoredProcedureCall call = session.createStoredProcedureCall("my_proc"); OutParameter p1Param = RegisteredParameter.outParameter(Long.class).named("p1Param"); InParameter p2Param = RegisteredParameter.inParam

Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Steve Ebersole
Again I am not so sure that registerInParameter is any more readable than registerParameter passed ParameterMode.IN. Registering a parameter is registering a parameter is registering a parameter to para-quote Ms Stein. To me the one thing that would make sense to split them out that way is what I

Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Gunnar Morling
IMO registerInParameter(String,Class) et al. read better than registerParameter(int,Class,ParameterMode), while the latter might be a bit simpler to use when writing the code. As code is more read than written, optimizing the read use case might be the better option. But I agree that six methods co

Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Steve Ebersole
I can definitely see a benefit to your registerOutParameter over registerParameter if we wanted to return specific types. But aside from that, I am not so sure that having to know 3 different sets of methods to register parameters: registerInParameter(int,Class) registerInParameter(String,Class)

Re: [hibernate-dev] Native Lucene Facets

2012-11-16 Thread Hardy Ferentschik
On 16 Jan 2012, at 6:31 PM, Nicolas Helleringer wrote: > I ve started some exploration around native Lucene facets support in > Hibernate Search Awesome. This was on my todo list for a long time, but never got around doing it. I think it is an important that we replace/extend the limited faceti

Re: [hibernate-dev] Stored procedure support

2012-11-16 Thread Gunnar Morling
Hi, FWIW, I'd prefer option #2 due to its type-safety. In #3 it's as you say challenging to control when extract() can be invoked. Maybe you could offer dedicated methods for the different parameter modes, making client code a bit shorter: RegisteredParameter p1Param = call.registerOutParameter(

[hibernate-dev] Native Lucene Facets

2012-11-16 Thread Nicolas Helleringer
I ve started some exploration around native Lucene facets support in Hibernate Search Before going too far, I would like some advice on if I step in the right direction or not. If you could please have a look at https://github.com/nicolashelleringer/hibernate-search/tree/HSEARCH-809 Niko ___

[hibernate-dev] Stored procedure support

2012-11-16 Thread Steve Ebersole
I thought I had written about this before to the list, but maybe not. Anyway, I added much enhanced support for calling database functions and procedures to master. But this is just my initial swag and as far as I know my eyes are the only ones that have seen it. So I wanted to get some feedb

Re: [hibernate-dev] change the source to 1.7 in build script?

2012-11-16 Thread Steve Ebersole
Because we never agreed to move to 1.7. And I don't think it makes sense. Java 6 is not even EOL yet (close, yes). The only 1.7 source requirement as I understand it is that jaxb "required" thing that you added. We do currently need *javac* from 1.7 to compile master (and metamodel since we