Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Gail Badner
See below... - Original Message - > From: "Gail Badner" > To: "Strong Liu" > Cc: "Hibernate hibernate-dev" > Sent: Tuesday, October 9, 2012 5:22:37 PM > Subject: Re: [hibernate-dev] Failing unit tests on metamodel branch > > Brett fixed TemporalBindingTest. > > I've figured out why th

Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Gail Badner
Brett fixed TemporalBindingTest. I've figured out why the rest are failing. I've fixed some and will mark others as @FailureExpectedWithNewMetamodel. I have to run out for 30 minutes or so, then I wrap it up and provide more details. I just wanted to let everyone know so we don't duplicate wor

Re: [hibernate-dev] Links to CI jobs on hibernate.org

2012-10-09 Thread Steve Ebersole
OK I "fixed it" (as good as it is going to get anyway) On Tue 09 Oct 2012 12:48:01 PM CDT, Gunnar Morling wrote: > Yes, I meant the top menu ("Build" -> "Continuous Integration"). > > 2012/10/9 Steve Ebersole : >> Gunnar, >> >> Do you mean in the menu option? That's seems to be from whoever last

Re: [hibernate-dev] Links to CI jobs on hibernate.org

2012-10-09 Thread Gunnar Morling
Yes, I meant the top menu ("Build" -> "Continuous Integration"). 2012/10/9 Steve Ebersole : > Gunnar, > > Do you mean in the menu option? That's seems to be from whoever last > updated the CI information. Hardy? > > > On Tue 09 Oct 2012 12:43:11 PM CDT, Steve Ebersole wrote: >> >> JBoss.org/Red

Re: [hibernate-dev] Links to CI jobs on hibernate.org

2012-10-09 Thread Steve Ebersole
Gunnar, Do you mean in the menu option? That's seems to be from whoever last updated the CI information. Hardy? On Tue 09 Oct 2012 12:43:11 PM CDT, Steve Ebersole wrote: > JBoss.org/Red Hat QA to properly unfuck their CI environment... > > In the meantime I'll take a look to see what can be do

Re: [hibernate-dev] Links to CI jobs on hibernate.org

2012-10-09 Thread Steve Ebersole
JBoss.org/Red Hat QA to properly unfuck their CI environment... In the meantime I'll take a look to see what can be done. On 10/09/2012 12:39 PM, Gunnar Morling wrote: > Hi all, > > I just noticed that some links to the Hibernate Jenkins jobs on > hibernate.org seem to be missing or wrong. > > M

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Steve Ebersole
The trouble is that you are glossing over where this "cache" comes from and how it comes into play. My original code was part of PersistenceContext (which is owned by Session). You explicitly say yours is not; or more correctly you say that in your code "cache" is call stack specific. So to m

[hibernate-dev] Links to CI jobs on hibernate.org

2012-10-09 Thread Gunnar Morling
Hi all, I just noticed that some links to the Hibernate Jenkins jobs on hibernate.org seem to be missing or wrong. More specifically, the link on the ORM project page points to the HV build, while the "Build" menu entry is disabled for all other sub-projects except Tools and Validator. Who would

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Emmanuel Bernard
If you have both the bytecode enhancement and the cache logic I am talking about the code would look like this. public EntityEntry getEntityEntry(Object entity) { if ( isEnhanced( entity ) ) { return ( (Enhanced) entity ).getEntityEntry(); } int cacheIndex = cache.size-1; if ( c

Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Strong Liu
On Oct 10, 2012, at 12:54 AM, Strong Liu wrote: > I just pushed a fix ( well, rollback one of my change ) and now only 9 > failures left > > > org.hibernate.test.collection.bag.PersistentBagTest > classMethod FAILED > org.hibernate.testing.junit4.CallbackException > Caused by: org

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Steve Ebersole
Well it does not keep track of EntityEntry specifically. It keeps track of the replacements. But that is the point. We have quite a few "context caches" already. PersistenceContext was intended for this lookup. It just suffers from a bad implementation of how that works atm.If I underst

Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Strong Liu
I just pushed a fix ( well, rollback one of my change ) and now only 9 failures left org.hibernate.test.collection.bag.PersistentBagTest > classMethod FAILED org.hibernate.testing.junit4.CallbackException Caused by: org.hibernate.tool.schema.spi.SchemaManagementException org.hiberna

[hibernate-dev] Hibernate Search Spatial: Units?

2012-10-09 Thread Sanne Grinovero
Hi Nicolas, In the QueryBuilder DSL a spatial Query has a nice option to define which units are being used: org.apache.lucene.search.Query luceneQuery = builder.spatial().onCoordinates( UserRange.class.getName() ) .within( 50, Unit.KM ).ofLatitude( centerLatitude

Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Brett Meyer
Many of those are related to HHH-7663 ("ManyToOne column names incorrect"). There were some fixes I made last week (especially in the discriminator area) that exposed the issue. Should @FailureExpectedWithNewMetamodels be added, or can we hold off shortly until 7663 is addressed? - Origin

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Emmanuel Bernard
On Tue 2012-10-09 10:30, Steve Ebersole wrote: > On Tue 09 Oct 2012 09:57:12 AM CDT, Emmanuel Bernard wrote: > >On Thu 2012-10-04 10:00, Steve Ebersole wrote: > >>See https://hibernate.onjira.com/browse/HHH-7667 > >> > >>I want to investigate expanding Hibernate's support for bytecode > >>enhanceme

Re: [hibernate-dev] Jira + GitHub

2012-10-09 Thread Steve Ebersole
Ok, Atlassian think the reason pushed commits do not show up sometimes is because of this: https://studio.atlassian.com/browse/BBC-232 Essentially anytime there is a large gap between the commit date/time and push date/time. Seems to fit the pattern I have witnessed between (a) pull requests

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Steve Ebersole
On Tue 09 Oct 2012 09:57:12 AM CDT, Emmanuel Bernard wrote: > On Thu 2012-10-04 10:00, Steve Ebersole wrote: >> See https://hibernate.onjira.com/browse/HHH-7667 >> >> I want to investigate expanding Hibernate's support for bytecode >> enhancement. I can see 3 main fronts to this: >> >> 1) offloadi

Re: [hibernate-dev] Bytecode enhancement

2012-10-09 Thread Emmanuel Bernard
On Thu 2012-10-04 10:00, Steve Ebersole wrote: > See https://hibernate.onjira.com/browse/HHH-7667 > > I want to investigate expanding Hibernate's support for bytecode > enhancement. I can see 3 main fronts to this: > > 1) offloading map lookups from the PersistenceContext . Currently we > kee

Re: [hibernate-dev] Failing unit tests on metamodel branch

2012-10-09 Thread Hardy Ferentschik
I was about to ask the same thing. Pulled the latest metamodel code yesterday and tried to compile, but also go a bunch of failures. --Hardy On 9 Jan 2012, at 7:25 AM, Gail Badner wrote: > I'm seeing a bunch of core unit test failures on metamodel branch. Is anyone > looking into these? > >