Re: [hibernate-dev] merge master into metamodel branch, again :)

2012-07-18 Thread Steve Ebersole
(1) and (2) are done. Tomorrow I will work on (3). On Tue 17 Jul 2012 03:16:46 AM CDT, Hardy Ferentschik wrote: > > On Jul 16, 2012, at 9:38 PM, Steve Ebersole wrote: > >> Thinking we should consider: >> 1) branching 4.1 >> 2) integrating my JPA 2.1 work onto master >> 3) merge master (with JPA 2

Re: [hibernate-dev] afterTransactionCompletion(status) in JtaTransaction

2012-07-18 Thread Steve Ebersole
I don't see an issue with changing that signature. On 07/18/2012 10:27 AM, Sanne Grinovero wrote: > Hi Steve, > thanks for the clarification. > > Wouldn't it make sense then to add the "int status" as an argument to > afterAfterTransaction as well? As it seems some code looks for this by > invokin

[hibernate-dev] SourceForge project

2012-07-18 Thread Steve Ebersole
Not sure if y'all are tracking what is going on at SourceForge. They have done a redesign of the site using a new hosting software they developed called Allura. We will need to upgrade to use Allura at some point. The upgrade has a few ramifications that I wanted to give everyone some time t

Re: [hibernate-dev] afterTransactionCompletion(status) in JtaTransaction

2012-07-18 Thread Sanne Grinovero
Hi Steve, thanks for the clarification. Wouldn't it make sense then to add the "int status" as an argument to afterAfterTransaction as well? As it seems some code looks for this by invoking tx.getStatus() in implementations of this method, but that seems unsafe as I've found cases in which this ge

Re: [hibernate-dev] afterTransactionCompletion(status) in JtaTransaction

2012-07-18 Thread Steve Ebersole
afterAfterTransaction is simply a part of the afterTransaction process. afterTransaction is split into a number of steps, afterAfterTransaction simply being the last step in that process. On 07/18/2012 05:15 AM, Sanne Grinovero wrote: > Hi all, > I'm puzzled about the implementation we have in >

[hibernate-dev] afterTransactionCompletion(status) in JtaTransaction

2012-07-18 Thread Sanne Grinovero
Hi all, I'm puzzled about the implementation we have in org.hibernate.engine.transaction.internal.jta.JtaTransaction regarding after-transaction completion handling. Looking at the two methods: afterAfterCompletion(); <-- note the "After - After" prefix afterTransactionCompletion(int status);