Re: [hibernate-dev] Fwd: Design : delegates and constructors

2012-07-17 Thread Steve Ebersole
Yep, thats definitiey a possibility as well. We have moved to builder pattern in lots of other places. On 07/17/2012 05:17 PM, Gunnar Morling wrote: > Hi, > > Maybe you could also use a builder for this: > > AbstractEntityManagerImpl = AbstractEntityManagerBuilder > .forDelegate(entityManag

[hibernate-dev] Fwd: Design : delegates and constructors

2012-07-17 Thread Gunnar Morling
Hi, Maybe you could also use a builder for this: AbstractEntityManagerImpl = AbstractEntityManagerBuilder .forDelegate(entityManagerFactory) .contextType(...) .transactionType(...) .property("foo", bar) .property("baz", qux) .build(); That way new attributes required for

Re: [hibernate-dev] Design : delegates and constructors

2012-07-17 Thread Gunnar Morling
Hi, Maybe you could also use a builder for this: AbstractEntityManagerImpl = AbstractEntityManagerBuilder .forDelegate(entityManagerFactory) .contextType(...) .transactionType(...) .property("foo", bar) .property("baz", qux) .build(); That way new attributes required for

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Hardy Ferentschik
>> That's what I have in mind as well. Basically what I tried to outline. > > Ok, but one point is that having this OverrideIndex may not be enough. As > Strong points out, a consideration here is the concept of > . Consider a class with no annotations, that is mapped > via orm.xml… that co

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Steve Ebersole
On Tue 17 Jul 2012 07:57:02 AM CDT, Hardy Ferentschik wrote: > Thanks for the info. I was missing this info and it gives "composite index" a > different meaning as well. > In the composite index is there a way to only query for annotation of a given > module? Say we get a composite index > and a

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Hardy Ferentschik
On Jul 17, 2012, at 2:42 PM, Steve Ebersole wrote: > On 07/17/2012 04:58 AM, Hardy Ferentschik wrote: >> >> On Jul 16, 2012, at 9:06 PM, Steve Ebersole wrote: >> >>> One such point of discussion was a common interface for "Index". >>> Unfortunately the name Index is already taken as in the main

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Steve Ebersole
As I pointed out in the reply to Hardy, I think there is a confusion here. I am not asking that we simply be able to hand Jandex an XML file and expect it to be able to figure out how to apply overrides. Thats not going to work. Again, what would be needed is some kind of SPI where we could t

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Steve Ebersole
CompositeIndex *does exist*. But its part of the AS codebase, not Jandex. On Tue 17 Jul 2012 05:13:18 AM CDT, Strong Liu wrote: > > On Jul 17, 2012, at 5:58 PM, Hardy Ferentschik > wrote: > >> >> On Jul 16, 2012, at 9:06 PM, Steve Ebersole wrote: >> >>> Strong, I for

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Steve Ebersole
On 07/17/2012 04:58 AM, Hardy Ferentschik wrote: > > On Jul 16, 2012, at 9:06 PM, Steve Ebersole wrote: > >> One such point of discussion was a common interface for "Index". >> Unfortunately the name Index is already taken as in the main Jandex >> class. So we came up with some other names. For t

Re: [hibernate-dev] Design : delegates and constructors

2012-07-17 Thread Sanne Grinovero
On 17 July 2012 03:57, Steve Ebersole wrote: > Design question on how we want to handle this notion of delegates that > ogm, search, etc extend and constructors... > > Specifically the notion that Sanne has asked for where ORM provides > implementations of stuff that OGM, Search, etc can just exte

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Strong Liu
On Jul 17, 2012, at 5:58 PM, Hardy Ferentschik wrote: > > On Jul 16, 2012, at 9:06 PM, Steve Ebersole wrote: > >> Strong, I forgot to mention that Jason completely agrees that changes to >> Jandex are needed. I agreed to prototype some of the things he and I >> discussed specifically in thi

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Strong Liu
I don't see there is a general way to integrate xml override into jandex, I think it is a very domain specific issue. and the "override" has lots of different requirements, for example "metadata-complete" org.hibernate.metamodel.internal.source.annotations.xml.mocker.IndexBuilder#mappingMetadata

Re: [hibernate-dev] JPA 2.1 progress

2012-07-17 Thread Hardy Ferentschik
On Jul 16, 2012, at 9:06 PM, Steve Ebersole wrote: > Strong, I forgot to mention that Jason completely agrees that changes to > Jandex are needed. I agreed to prototype some of the things he and I > discussed specifically in this code base and hand them back to him for > integration back into

Re: [hibernate-dev] merge master into metamodel branch, again :)

2012-07-17 Thread Hardy Ferentschik
On Jul 16, 2012, at 9:38 PM, Steve Ebersole wrote: > Thinking we should consider: > 1) branching 4.1 > 2) integrating my JPA 2.1 work onto master > 3) merge master (with JPA 2.1) to metamodel branch +1 ___ hibernate-dev mailing list hibernate-dev@lis