Re: [hibernate-dev] HSEARCH-1084 build failed

2012-04-25 Thread Nicolas Helleringer
It worked ! Build successfull, many thanks =) Niko 2012/4/25 Sanne Grinovero > HSEARCH-1106 was resolved (thanks Gail!): could you please try again? > > Sanne > > On 25 April 2012 11:16, Sanne Grinovero wrote: > > Thanks! > > so it's not limited to one of our CI machines :) > > > > Gail was h

Re: [hibernate-dev] HSEARCH-1084 build failed

2012-04-25 Thread Sanne Grinovero
HSEARCH-1106 was resolved (thanks Gail!): could you please try again? Sanne On 25 April 2012 11:16, Sanne Grinovero wrote: > Thanks! > so it's not limited to one of our CI machines :) > > Gail was having the same problem yesterday night, and seems to have a > solution. > > Created HSEARCH-1106,

Re: [hibernate-dev] HSEARCH-1084 build failed

2012-04-25 Thread Gail Badner
I created a pull request: https://github.com/hibernate/hibernate-search/pull/280 Gail - Original Message - > From: "Sanne Grinovero" > To: "Nicolas Helleringer" > Cc: hibernate-dev@lists.jboss.org > Sent: Wednesday, April 25, 2012 3:16:56 AM > Subject: Re: [hibernate-dev] HSEARCH-1084 bui

Re: [hibernate-dev] [OGM] MongoDB safe mode

2012-04-25 Thread Guillaume SCHEIBEL
a JIRA has been created OGM-165 (Add support for the SafeMode) 2012/4/25 Guillaume SCHEIBEL > Emmanuel, we should also add a support of the WriteResult (whether or not > the safemode is set). > What do you think ? > > Guillaume > > 2012/4/25 Guillaume

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Guillaume SCHEIBEL
Simply because I didn't know this annotation :) next time I won't say anything ;) (at least I've learn something) Guillaume 2012/4/25 Emmanuel Bernard > Why not use @ElementCollection for such a case instead of @OneToMany? > > > On 25 avr. 2012, at 17:54, Guillaume SCHEIBEL < > guillaume.sch

Re: [hibernate-dev] [OGM] MongoDB safe mode

2012-04-25 Thread Guillaume SCHEIBEL
Emmanuel, we should also add a support of the WriteResult (whether or not the safemode is set). What do you think ? Guillaume 2012/4/25 Guillaume SCHEIBEL > I can take it > > > 2012/4/25 Emmanuel Bernard > >> BTW, by default MongoDB drivers do not wait for the operation to be >> executed on th

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Emmanuel Bernard
Why not use @ElementCollection for such a case instead of @OneToMany? On 25 avr. 2012, at 17:54, Guillaume SCHEIBEL wrote: > No, I don't think so > > The first case could be: > class Post { > @OneToMany > List comments; > //... > } > > and so in mongodb > > { > "_id": Object

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Guillaume SCHEIBEL
No, I don't think so The first case could be: class Post { @OneToMany List comments; //... } and so in mongodb { "_id": ObjectId("4f981b173572f2a35c3826f8"), "title": "About collections", "comments": [ { "author": "Emmanuel", "content": "my comment"

Re: [hibernate-dev] [OGM] Issue with accepting mongodb in master

2012-04-25 Thread Guillaume SCHEIBEL
I'm okay with this approach. Therefore, we have to skip the hibernate.ogm.mongodb.host and port properties. 2012/4/25 Sanne Grinovero > The relevant settings I have in ~/.m2/settings.xml : > > Working already: > > >jboss-public-repository >forceJava6 >mongodb > > > If w

Re: [hibernate-dev] [OGM] Issue with accepting mongodb in master

2012-04-25 Thread Sanne Grinovero
The relevant settings I have in ~/.m2/settings.xml : Working already: jboss-public-repository forceJava6 mongodb If we add properties for hostname, you could have in the same file as well: mongodb 172.17.130.62

Re: [hibernate-dev] HHH-7265/HSEARCH-1087 ConcurrentModificationException

2012-04-25 Thread Steve Ebersole
My immediate thought would be to leverage Session's notion of auto closing after transaction (org.hibernate.cfg.Settings#isAutoCloseSessionEnabled). That is all the Synchronization in EntityManagerImpl is doing. Those hooks are already in place, maybe just add a way for EntityManager to tell

Re: [hibernate-dev] [OGM] Issue with accepting mongodb in master

2012-04-25 Thread Sanne Grinovero
In the pull request I've sent the MongoDB tests are disabled, one would need to enable it using the Maven profile example: > mvn clean install -Pmongodb If you run just "mvn clean install", it will skip building the MongoDB module. I know it's not ideal as we would like everyone to test for it,

[hibernate-dev] [OGM] Issue with accepting mongodb in master

2012-04-25 Thread Emmanuel Bernard
I'd like to accept MongoDB's work in OGM's master branch. There is one big elephant in the room. If I don't have MongoDB running in localhost, I can pass the test and thus I can't do a release. That's especially a problem for me as my MongoDB instance is in a VM and thus not localhost. I can't u

Re: [hibernate-dev] [OGM] MongoDB safe mode

2012-04-25 Thread Guillaume SCHEIBEL
I can take it 2012/4/25 Emmanuel Bernard > BTW, by default MongoDB drivers do not wait for the operation to be > executed on the server to return. So you could insert a data that would > fail but not be noticed by the client. > To avoid that, you need to pass the safe=true option. > > I think we

[hibernate-dev] [OGM] MongoDB safe mode

2012-04-25 Thread Emmanuel Bernard
BTW, by default MongoDB drivers do not wait for the operation to be executed on the server to return. So you could insert a data that would fail but not be noticed by the client. To avoid that, you need to pass the safe=true option. I think we should offer an option to be safe. Should it be the

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Sanne Grinovero
Sounds like very reasonable. Maybe it's worth running tests for longer time? When some work on Infinispan performance we noticed that the "warmup" time of the JVM was significantly larger than expected; in my initial tests I was discarding the first 5 minutes of metrics, but I actually needed to d

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Alan F
Hi, What I was hoping to avoid was MongoDB shifting data in a collection to make room for new elements in a document (ie. RowKey), as it appears to be quite an expensive operation. I was noticing a connection between many of the big spikes in my results and the following log entries in mongodb

Re: [hibernate-dev] HSearch compile issue

2012-04-25 Thread Sanne Grinovero
Hi Gail, thanks! no this wasn't having a jira yet, just related to a failing build on one of the Jenkins builds. Created right now as HSEARCH-1106, all yours. It's also related to the thread by Nicolas, apparently unable to build Search for the same reason: see the ML thread "HSEARCH-1084 build f

Re: [hibernate-dev] HSEARCH-1084 build failed

2012-04-25 Thread Sanne Grinovero
Thanks! so it's not limited to one of our CI machines :) Gail was having the same problem yesterday night, and seems to have a solution. Created HSEARCH-1106, assigned to her so she can send a pull request. Sanne On 25 April 2012 09:46, Nicolas Helleringer wrote: > Last night I was on my home

Re: [hibernate-dev] [OGM] MongoDB dialect and treatment of _id

2012-04-25 Thread Emmanuel Bernard
Any more thoughts on that? I like Sanne's approach but it means that people not use @Column will very often have id and _id and of course that we need to maintain secondary indexes. On 10 avr. 2012, at 16:26, Sanne Grinovero wrote: > Why should we not rely on the flexibility of the object/physic

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Emmanuel Bernard
On 25 avr. 2012, at 10:05, Guillaume SCHEIBEL wrote: > At the very beginning, I thought to manage association like this: > Case of @OneTo* associations could be managed like embeddeds (for me it makes > sens and close to the mongo way) > Case of @ManyTo* associations could be managed in a usual

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Emmanuel Bernard
On 25 avr. 2012, at 10:05, Guillaume SCHEIBEL wrote: > And regarding the documentation > http://www.mongodb.org/display/DOCS/Database+References#DatabaseReferences-DBRef > it could be an idea :) >From what I understand of DBRefs, they bring no value to us in the OGM >context. They can even be

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Emmanuel Bernard
But you still need the collect and the event to release it. On 25 avr. 2012, at 10:59, Sanne Grinovero wrote: > Isn't Hibernate ORM already providing such a service via the > Session/Persistence context/"L1" container ? > > We might be able to take advantage of existing events to control the > b

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Sanne Grinovero
Isn't Hibernate ORM already providing such a service via the Session/Persistence context/"L1" container ? We might be able to take advantage of existing events to control the batching on MongoDB. On 25 April 2012 08:35, Emmanuel Bernard wrote: > I don't think we need an actual multi threaded cac

Re: [hibernate-dev] HSEARCH-1084 build failed

2012-04-25 Thread Nicolas Helleringer
Last night I was on my home desktop PC. Today on my pro laptop with windows 7 x64 it builds on _25 and _31. Still trying to figure what the differences are between my two environnements. niko 2012/4/25 Nicolas Helleringer > I did upgrade to _31 and update my jdk location in my settings.xml but

Re: [hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Guillaume SCHEIBEL
At the very beginning, I thought to manage association like this: - Case of @OneTo* associations could be managed like embeddeds (for me it makes sens and close to the mongo way) - Case of @ManyTo* associations could be managed in a usual way (association collections, etc.) Of course,

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Emmanuel Bernard
I don't think we need an actual multi threaded cache. the flush operation in Hibernate is not multi threaded, neither is the session. A simple Map (or a better append only structure) will suffice, I think. On 25 avr. 2012, at 09:32, Guillaume SCHEIBEL wrote: > Hi all, > > What do you think abou

[hibernate-dev] [OGM] Mapping associations in MongoDB

2012-04-25 Thread Emmanuel Bernard
## Mapping strategy I think we have explored three main options while implementing the association mapping in MongoDB 1. Put the assoc info within the entity document we navigate from 2. Put the assoc info in a dedicated document and dedicated collection 3. Put the assoc info in n documents (one

Re: [hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Guillaume SCHEIBEL
Hi all, What do you think about using the Ehcache module to store the data between 2 flushes ? I will open a JIRA about this point if it has not already been done. Guillaume 2012/4/25 Emmanuel Bernard > Hi Alan and all, > > I have been researching the spikes issue you encounter in the stress t

[hibernate-dev] [OGM] MongoDB time spikes

2012-04-25 Thread Emmanuel Bernard
Hi Alan and all, I have been researching the spikes issue you encounter in the stress test from a theoretical point of view. You were trying a different associations storage approach (splitting associations as one row per document rather than the whole association per document). Does that retur