Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Strong Liu
hibernate version is not injected by the injection plugin https://hibernate.onjira.com/browse/HHH-6412 --- Strong Liu http://hibernate.org http://github.com/stliu On Aug 23, 2011, at 9:41 PM, Scott Marlow wrote: > Oh, apologies for hijacking > > /me going for more coffee! ;) > > On 08

Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Scott Marlow
Oh, apologies for hijacking /me going for more coffee! ;) On 08/23/2011 09:24 AM, Hardy Ferentschik wrote: > Hi, > > FYI, the version should automatically be set by the build process. The > actual > java file contains the token "[WORKING]" which gets replaces by the > version specified > in the b

Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Hardy Ferentschik
Hi, FYI, the version should automatically be set by the build process. The actual java file contains the token "[WORKING]" which gets replaces by the version specified in the build file. The magic which makes this happen is the InjectionPlugin (a gradle plugin) which lives in the buildSrc d

Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Scott Marlow
I don't know how to do a Hibernate release but it seems like some releases don't have the org.hibernate.Version set (default of "[WORKING]" is occasionally used). It would be nice if this was set for any further releases (AS7 is trying to use this to determine the difference between a 3.x or 4

Re: [hibernate-dev] Hibernate 3.x with JBoss7 and new TransactionManager lookup

2011-08-23 Thread Scott Marlow
On 08/23/2011 04:20 AM, Sanne Grinovero wrote: > Hi Scott, > since you've added a Hibernate 3 compatibility module to JBoss7, > shouldn't we add an appropriate TransactionManagerLookup to Hibernate > *3* core as well? Or is this not needed? > I think it could be useful for Hibernate 3 applications

Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Sanne Grinovero
2011/8/23 Emmanuel Bernard : > Sure, you can trigger the release. I agree with your suggestions on issue > resolution except that I would not bump major (nor minor) version numbers for > the dependencies. Only micro. > For example, Infinispan 5 has broken compatibility on us several times during

Re: [hibernate-dev] Releasing 3.4.1 ?

2011-08-23 Thread Emmanuel Bernard
Sure, you can trigger the release. I agree with your suggestions on issue resolution except that I would not bump major (nor minor) version numbers for the dependencies. Only micro. For example, Infinispan 5 has broken compatibility on us several times during the CR cycle. I would not dare to as

Re: [hibernate-dev] Hibernate 3.x with JBoss7 and new TransactionManager lookup

2011-08-23 Thread Sanne Grinovero
Hi Scott, since you've added a Hibernate 3 compatibility module to JBoss7, shouldn't we add an appropriate TransactionManagerLookup to Hibernate *3* core as well? Or is this not needed? 2011/8/23 Scott Marlow : > Some related jiras (all fixed on 4.0 only): > > HHH-6543 - JBoss AS7 transaction mana