Re: [hibernate-dev] CascadeStyle, CascadeType etc

2011-06-24 Thread Hardy Ferentschik
On Fri, 24 Jun 2011 15:36:28 +0200, Steve Ebersole wrote: > First, I think CascadeType should be changed up a bit. Currently it > contains some "aggregate" values (ALL, ALL_DELETE_ORPHAN). I'd like to > keep this limited to just the "atomic" cascade-types. Rather than the > map lookups here

[hibernate-dev] CascadeStyle, CascadeType etc

2011-06-24 Thread Steve Ebersole
I think this warranted a separate discussion. First, I think CascadeType should be changed up a bit. Currently it contains some "aggregate" values (ALL, ALL_DELETE_ORPHAN). I'd like to keep this limited to just the "atomic" cascade-types. Rather than the map lookups here based on the enum va

Re: [hibernate-dev] metamodel thoughts

2011-06-24 Thread Max Rydahl Andersen
On Jun 24, 2011, at 02:32, Steve Ebersole wrote: > Here is one of the tests I pointed you to before: > https://github.com/hibernate/hibernate-core/blob/master/hibernate-core/src/test/java/org/hibernate/metamodel/binding/SimpleValueBindingTests.java > > It shows the basic steps. Pretty similar t

Re: [hibernate-dev] Static constants in org.hibernate.engine.internal.Versioning

2011-06-24 Thread Hardy Ferentschik
Hi, I am also for moving to enums. I am not sure whether or why this should go to org.hibernate.engine.spi though. I am still at odds with this package refactoring. I think we discussed once before that there are several places in the code which would benefit from the introduction of an enu

Re: [hibernate-dev] time to remove deprecated hibernate annotations?

2011-06-24 Thread Hardy Ferentschik
On Fri, 24 Jun 2011 08:58:19 +0200, Strong Liu wrote: > org.hibernate.annotations.CollectionOfElements > org.hibernate.annotations.ForceDiscriminator > org.hibernate.annotations.MapKey > org.hibernate.annotations.MapKeyManyToMany > > those annotations above have been marked deprecated for a long