Alright, I'll change this then as proposed.
2011/3/1 Emmanuel Bernard
> Looks fine to me. I was concerned about passing Method around as well.
>
> On 1 mars 2011, at 00:29, Gunnar Morling wrote:
>
> Hi,
>
> I pretty much finished the implementation of the meta data API related to
> method level
On Tue, 01 Mar 2011 17:34:58 +0100, Emmanuel Bernard
wrote:
>>> FacetRequest request =
>>> carBuilder
>>> .facet()
>>>.named("prices")
>>>.range() //or should it be range(Integer.class)
>>>.onField("price")
>>>.from(0).to(1000).excludeLimit()
>>>.from(1000).to(1500).exclude
On 1 mars 2011, at 15:08, Hardy Ferentschik wrote:
> Thanks for the feedback. Answers inline
>
> On Tue, 01 Mar 2011 14:39:58 +0100, Emmanuel Bernard
> wrote:
>
>> To avoid the problem of Constructor multiplications and still use immutable
>> objects use a builder to collect the information
Thanks for the feedback. Answers inline
On Tue, 01 Mar 2011 14:39:58 +0100, Emmanuel Bernard
wrote:
> To avoid the problem of Constructor multiplications and still use
> immutable objects use a builder to collect the information and create
> the object out of it. The constructor can even b
Looks fine to me. I was concerned about passing Method around as well.
On 1 mars 2011, at 00:29, Gunnar Morling wrote:
> Hi,
>
> I pretty much finished the implementation of the meta data API related to
> method level constraints for Hibernate Validator (see
> https://github.com/gunnarmorling/
Awesome feedback :)
Let's make sure we can support these sue cases in the API or know how to extend
the API to cover them in the future. Once we are safe here we can iterate over
the underlying implementation.
On 28 févr. 2011, at 19:56, Marc Schipperheyn wrote:
> My two cents:
> * Most of the
Hi Hardy,
Nice job.
Here are a few comments in random order:
To avoid the problem of Constructor multiplications and still use immutable
objects use a builder to collect the information and create the object out of
it. The constructor can even be package private
My initial reaction was that fa
On Tue, 01 Mar 2011 00:29:49 +0100, Gunnar Morling
wrote:
> I pretty much finished the implementation of the meta data API related to
> method level constraints for Hibernate Validator (see
> https://github.com/gunnarmorling/hibernate-validator/commits/HV-371).
Looks great. I added a few line
