Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Gustavo Fernandes
IMHO there are lots of extra info to potentially return to the user beyond a list of query results. Besides a boolean indicating partial results and a long indicating query time, I can imagine other cases, such as HSEARCH-623 (facets). Other examples would be highlight information, Morelikethis

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Sanne Grinovero
+1 Il giorno 06/nov/2010 18:07, "Emmanuel Bernard" ha scritto: Yes except that getResultSize() can have a side effect (ie. call the actual query). If things become more complex, we can introduce this object but probably not for hasPartialResults alone. Make sense? On 6 nov. 2010, at 16:50, San

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Emmanuel Bernard
Yes except that getResultSize() can have a side effect (ie. call the actual query). If things become more complex, we can introduce this object but probably not for hasPartialResults alone. Make sense? On 6 nov. 2010, at 16:50, Sanne Grinovero wrote: > there's a similar case already: > query.ge

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Sanne Grinovero
there's a similar case already: query.getResultSize() //relates to the last returned list and so looking at the complexity of proposed alternatives, I'm not strongly against your original suggestion to provide a method on the query object. Alternatively we might consider there might be enough goo

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Emmanuel Bernard
The other option I've been thinking about is to get limitFetchTime() / limitTimeAllowedTo() to return a Future object or some equivalent notion say a BooleanHolder. BooleanHolder hasPartialResults = query.limitTimeAllowedTo(500, MILLISECONDS, hasPartialResults); query.list(); if ( hasPartialRe

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Emmanuel Bernard
You'll need to extend: - List - Iterator - ScrollableResults Not sure that's a good thing. You can reuse the query as long as you check hasPartialResults() before calling list/iterate/scroll query again. PS: we should add tests about query reusability, I'm not sure it works as expected toda

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Gustavo Fernandes
Solr uses 'timeAllowed' to provide the same functionality, it's think it's a nice name! On 6 Nov 2010 11:33, "Sanne Grinovero" wrote: > Hello, > about naming I have no better ideas: > .limitFetchTime() //slightly different, not very happy about it either > > about API, does it really make sense to

Re: [hibernate-dev] HSEARCH-615 Support time-constrained queries returning the first available results

2010-11-06 Thread Sanne Grinovero
Hello, about naming I have no better ideas: .limitFetchTime() //slightly different, not very happy about it either about API, does it really make sense to have hasPartialResults() as a method of the Query? It should be a List property I think - I have no strong opinions about this as I don't like