Re: [hibernate-dev] release plans for Search?

2010-04-03 Thread Amin Mohammed-Coleman
Hi Sanne I'm looking into this now. Hopefully I'll get the coding conventions right this time! Thanks Amin On 3 Apr 2010, at 22:47, Sanne Grinovero wrote: > Hi Amin, > I updated your patch and attached it to HSEARCH-421, hope you've seen > it and are able to look in

Re: [hibernate-dev] release plans for Search?

2010-04-03 Thread Sanne Grinovero
2010/4/3 Emmanuel Bernard : > Ah cool, we are getting there :) > Looking at it quickly, can you use tabs, not space for indentation? That's > our coding conventions. > > One open question I had last time was one error handler for sync and async, > vs one for sync and one for async. What was decid

Re: [hibernate-dev] release plans for Search?

2010-04-03 Thread Sanne Grinovero
Hi Amin, I updated your patch and attached it to HSEARCH-421, hope you've seen it and are able to look into it, especially the PerDPQueueProcessor needs some more thoughts. Also I was going to ask you to prepare a test as I couldn't really figure it all out by reading the code, but as it's quite t

Re: [hibernate-dev] release plans for Search?

2010-04-03 Thread Emmanuel Bernard
Hey Sanne and all, One thing we did not discuss Friday that I wanted your input on is the status on optional dependencies. Can you check out these dependencies and tell me which one you think should be mandatory (solr's analyzer framework is an example). http://opensource.atlassian.com/projects/

Re: [hibernate-dev] release plans for Search?

2010-04-03 Thread Emmanuel Bernard
Ah cool, we are getting there :) Looking at it quickly, can you use tabs, not space for indentation? That's our coding conventions. One open question I had last time was one error handler for sync and async, vs one for sync and one for async. What was decided? What was the reasoning? On 2 avr.