Re: [hibernate-dev] Huge patch for Search

2010-02-08 Thread Emmanuel Bernard
So someone changing the behavior of an analyzer should fallback to the previous behavior if an old version number is passed. What I fear with this approach is that: - you cannot see at compile time which analyzer has changed and which one has not (which is what people are interested in in the f

Re: [hibernate-dev] Huge patch for Search

2010-02-08 Thread Sanne Grinovero
ok will fix and apply About the Version, I've started a thread on Lucene-dev and got many interesting answers and insight: http://mail-archives.apache.org/mod_mbox/lucene-java-dev/201002.mbox/%3c50e5f6251002070933p4f9e6150t27ef86fd36ea5...@mail.gmail.com%3e Cheers, Sanne 2010/2/8 Emmanuel Bernar

Re: [hibernate-dev] Huge patch for Search

2010-02-08 Thread Emmanuel Bernard
Right, the spreading of this constant is a bit worrisome but it seems to be the way Lucene is going. I think getTargetLuceneVersion() is a good addition to SearchTestCase. In the hopefully near future, this constant will be a parameter of Hibernate Search at runtime. The DSL will absorb this com