On 12/14/2009 01:59 PM, Guenther Demetz wrote:
> Hi hibernate developers,
>
> Since various hibernate releases (3.2, 3.3 , 3.5beta2) I'm still
> wondering about following warning when using hibernate with
> JDBCTransactionFactory (= without JTA integration):
>
> TransactionManagerLookupFactory:80
Comments inline:
On Tue, Dec 15, 2009 at 10:46 AM, Emmanuel Bernard
wrote:
> Hello, thanks for your work!
>
> I don't have much to comment except that;
> - we use tabs for indentation
My fault, should have looked up your code style first! Will fix for
the final patch. Are they somewhere availab
Hello, thanks for your work!
I don't have much to comment except that;
- we use tabs for indentation
- logs are a bit verbose but I can work on that when applying the patch (will
be faster then explaining everything)
- are you sure you can statically reference ConcurrentStatisticsImpl wo
fail
Well yes, ideally I would like to get SearchMapping as an interface but the big
question becomes: how do I get the SearchMapping instance from? and how easy is
that.
On 14 déc. 2009, at 18:58, Amin Mohammed-Coleman wrote:
> Hi Sanne
>
> Thanks for your reply. I was thinking mostly around impl
AS we discussed initially, I do think it's the best approach to prevent future
mistakes in the API extension.
While interfaces will work, I don't think an abstract class scheme would work
though. I tried on a similar API and it did not cut it for me at the time.
Emmanuel
On 14 déc. 2009, at 15
ahahah, touché.
On 14 déc. 2009, at 18:39, Steve Ebersole wrote:
> Well we can also do what you suggest and you can be the one fielding bug
> reports about some other providers jar if you wish ;)
>
> On Mon, 2009-12-14 at 17:38 +0100, Emmanuel Bernard wrote:
>> If you guys like that. But you wil
