Re: [hibernate-dev] Programmatic Mapping patch

2009-11-25 Thread Amin Mohammed-Coleman
Hi Ive updated the ProvidedId mapping test to include the changes you made. Also added some more factory methods in the ContainedInMapping. On a side note, I've made SearchMapping an interface but wasn't sure how to create it, is there a class I can use to construct a new search mapping? The Sea

Re: [hibernate-dev] Programmatic Mapping patch

2009-11-25 Thread Amin Mohammed-Coleman
Hi In relation to fullTextFilterDef, that was my initial thoughts but I noticed that the full text filter definition (annotation) was built from an entity in searchFactoryImpl private void bindFilterDefs(XClass mappedXClass) { FullTextFilterDef defAnn = mappedXClass.getAnnotation( FullTextFilte

Re: [hibernate-dev] Programmatic Mapping patch

2009-11-25 Thread Sanne Grinovero
About 2) 2A - fullTextFilterDef: While it's ok for the annotation to stay on an indexed entity, I don't see a named filter as coupled/related to an entity, shouldn't this be part of global settings? 2B - analyzerDiscriminator yes makes sense only on an indexed entity, not on indexedembeeded as it'

Re: [hibernate-dev] Programmatic Mapping patch

2009-11-25 Thread Emmanuel Bernard
Hey, Let's release Beta1 as it is except for 5 and 6 and take time to try the API before refining it. On 25 nov. 09, at 17:29, Amin Mohammed-Coleman wrote: > Hi All, > > Would it be possible get feedback with regards to points 2, 3 and > 4. I can create patch to address those issues. > > Ch

Re: [hibernate-dev] Programmatic Mapping patch

2009-11-25 Thread Amin Mohammed-Coleman
Hi All, Would it be possible get feedback with regards to points 2, 3 and 4. I can create patch to address those issues. Cheers Amin On Fri, Nov 20, 2009 at 2:20 PM, Emmanuel Bernard wrote: > Hi Amin, > I've committed your patch, thanks! > There is still some work and questions remaining but

Re: [hibernate-dev] firing proper events after HQL?

2009-11-25 Thread Adam Warski
Either a "lazy structure" or the table name + utility method to read content of the table, as that's the operation all users of such listeners would need. Adam On Nov 24, 2009, at 9:09 PM, Emmanuel Bernard wrote: > If you return a "lazy structure", we could avoid the overhead unless the data >

Re: [hibernate-dev] firing proper events after HQL?

2009-11-25 Thread Adam Warski
But is there a way to get the list of ids generated by an insert after it has completed? (before it would be hard to do :) ). Adam > Well only update and delete work the way I described wrt a temporary > table. inserts are handled completely differently. > > On Tue, 2009-11-24 at 19:53 +0100,