Re: [hibernate-dev] Hibernate Search: ReaderProvider.destroy()

2008-07-19 Thread Emmanuel Bernard
Good In DP it's stop() as the opposite of start() (initialize() has a different semantic for DPs) And in RP it's destroy() as the opposite of initialize() like the Hibernate EventListeners There is consistency :) -- Emmanuel Bernard http://in.relation.to/Bloggers/Emmanuel | http://blog.emma

Re: [hibernate-dev] Hibernate Search: ReaderProvider.destroy()

2008-07-19 Thread Sanne Grinovero
Yes I agree, good catch. Additionally I could add some minor performance improvement using a background thread in SharingBufferReaderProvider, (to have the file-closing operations of unneeded segments run async) but didn't implement that as I was lacking a shutdown hook. But DirectoryProvider(s) a