Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread Steve Ebersole
On Thursday 20 September 2007 12:20:10 pm James Carman wrote: > My point is that the directory structure doesn't match that of the > trunk, so it will be very difficult to merge the changes from the > HQL_ANTLR_2 branch back in (I'm no SVN expert, so I may be mistaken > here).  So, I guess I can co

Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread James Carman
Another problem with the code in the branch is that it uses Commons Logging, whereas the code in the trunk uses SLF4J. On 9/20/07, James Carman <[EMAIL PROTECTED]> wrote: > My point is that the directory structure doesn't match that of the > trunk, so it will be very difficult to merge the changes

Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread James Carman
My point is that the directory structure doesn't match that of the trunk, so it will be very difficult to merge the changes from the HQL_ANTLR_2 branch back in (I'm no SVN expert, so I may be mistaken here). So, I guess I can copy your work from the HQL_ANTLR_2 branch into my local copy of the tru

Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread Steve Ebersole
On Thursday 20 September 2007 11:25:00 am James Carman wrote: > Well, how difficult would it be to get the HQL_ANTLR_2 branch > mavenized so that it mimics the layout of the trunk?  Wouldn't that > branch, as it currently sits, be very difficult to merge back into the > trunk?  Could we make a copy

Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread James Carman
Well, how difficult would it be to get the HQL_ANTLR_2 branch mavenized so that it mimics the layout of the trunk? Wouldn't that branch, as it currently sits, be very difficult to merge back into the trunk? Could we make a copy of the trunk to another branch so that we can copy over your changes

Re: [hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread Steve Ebersole
On Thursday 20 September 2007 09:14:47 am James Carman wrote: > What do you guys think about this... > > fromClause > > : FROM^ { weakKeywords(); } fromRange ( onJoin | pathJoin | COMMA! { > > weakKeywords(); } fromRange )* > ; > > onJoin > > : ( ( ( LEFT | RIGHT ) (OUTER)? ) | FULL

[hibernate-dev] HQL Grammar for "ON" joins...

2007-09-20 Thread James Carman
What do you guys think about this... fromClause : FROM^ { weakKeywords(); } fromRange ( onJoin | pathJoin | COMMA! { weakKeywords(); } fromRange )* ; onJoin : ( ( ( LEFT | RIGHT ) (OUTER)? ) | FULL | INNER )? JOIN^ identifier asAlias ON^ logicalExpression ; pathJoin