Re: Turning off tests leads to a different store item

2023-11-02 Thread Suhail
Simon Tournier writes: > On Thu, 02 Nov 2023 at 15:25, Suhail wrote: > >> Yes, with the test derivation being something like a "fixed-output >> derivation". [[info:guix#Derivations][From the manual]]: > > No, it cannot be a “fixed-output” derivation… > > …because we cannot know in advance the ex

Re: Turning off tests leads to a different store item

2023-11-02 Thread Suhail
Greg Hogan writes: > On Thu, Nov 2, 2023 at 11:26 AM Suhail wrote: >> Perhaps not all. The thing that sets the "check" phase (#:tests?) apart >> from the rest is that it's an identity transform with a >> side-effect. i.e., it simply reports on the state of its input (i.e., >> the build artifact)

Re: Turning off tests leads to a different store item

2023-11-02 Thread Simon Tournier
On Thu, 2 Nov 2023 at 18:02, Simon Tournier wrote: > /gnu/store/7fc3933yqq9hnp4rrxp84gxdpg270k7v-hi-build-2.10 > /gnu/store/7fc3933yqq9hnp4rrxp84gxdpg270k7v-hi-test-2.10 Here is a typo when copy/pasting from my Shell to my Email composer and editing for more clearity. Obviously, the two items d

Re: Turning off tests leads to a different store item

2023-11-02 Thread Simon Tournier
Hi, On Thu, 02 Nov 2023 at 15:25, Suhail wrote: > It certainly seems to be the case. Would you know the specific place(s) > in the source code (in addition to guix/derivations.scm and > guix/store.scm) that would be relevant for this discussion? I guess all the build systems: guix/build/*.scm a

Re: Turning off tests leads to a different store item

2023-11-02 Thread Greg Hogan
On Thu, Nov 2, 2023 at 11:26 AM Suhail wrote: > Perhaps not all. The thing that sets the "check" phase (#:tests?) apart > from the rest is that it's an identity transform with a > side-effect. i.e., it simply reports on the state of its input (i.e., > the build artifact) leaving the build artifact

Re: Turning off tests leads to a different store item

2023-11-02 Thread Suhail
Simon Tournier writes: > On Wed, 01 Nov 2023 at 17:52, Suhail wrote: > >> If not, why should skipping the tests result in a different >> derivation tree? > > The store path is different because it hashes all the inputs, included > the builder script; from my understanding. It certainly seems to

Re: Unable to build "Ten Years Reproducibility Challenge" paper

2023-11-02 Thread Simon Tournier
Hi, On Wed, 01 Nov 2023 at 11:09, Vagrant Cascadian wrote: >> Please bear with me as I again belabor the same point without receiving >> public support. Building packages should be separate from testing them. > > In general, I agree... sort of. > > I do see value in build-time tests preventing