Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Erik Faye-Lund
I ended up reverting the change, and I can't find an obcious way to support both old and new versions with the same source file. The Android SDK also ships a pre-3.x version of Bison, so you're not the only one affected. Also, Chocolatey doesn't provide a new enough version of Bison for Windows ei

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Hans Åberg
> On 22 May 2019, at 08:54, Erik Faye-Lund wrote: > > The problem is that Bison doesn't seem to have any mechanism for doing > statements like these conditionally. The only way around that that I > can see is to pre-process the source files somehow. But especially with > three different build s

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Erik Faye-Lund
On Wed, 2019-05-22 at 15:21 +0200, Hans Åberg wrote: > > On 22 May 2019, at 08:54, Erik Faye-Lund < > > erik.faye-l...@collabora.com> wrote: > > > > The problem is that Bison doesn't seem to have any mechanism for > > doing > > statements like these conditionally. The only way around that that > >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Hans Åberg
> On 22 May 2019, at 15:31, Erik Faye-Lund wrote: > > On Wed, 2019-05-22 at 15:21 +0200, Hans Åberg wrote: >> >> One can set the distribution so that the Bison sources are only re- >> compiled if modified. > > This would only work for tarballs, though, no? That is what I have in mind. > Othe

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Hans Åberg
> On 22 May 2019, at 15:41, Hans Åberg wrote: > >> Otherwise we'd need to >> commit the generated files, which is tricky because the location >> depends on where the build-dir is located, and would probably not play >> well with different developers having different versions, leading to >> varia

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Akim Demaille
Hi Erik, > Le 22 mai 2019 à 08:54, Erik Faye-Lund a écrit > : > > I ended up reverting the change [from-%error-verbose to %define parse.error > verbose] , and I can't find an obcious way to > support both old and new versions with the same source file. Well, you just disable warnings about de

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-22 Thread Akim Demaille
> Le 22 mai 2019 à 18:06, Akim Demaille a écrit : > > Hi Erik, > >> Le 22 mai 2019 à 08:54, Erik Faye-Lund a >> écrit : >> The Android SDK also ships a pre-3.x version of Bison, so you're not >> the only one affected. Also, Chocolatey doesn't provide a new enough >> version of Bison for Wind

Bison 3.4.1 released [stable]

2019-05-22 Thread Akim Demaille
The Bison team is sad to announce the crash of Bison 3.4. May its cores rest in peace. Rejoice! Bison 3.4 is born again! And he shall be called Bison 3.4.1. A particular focus was put on improving the diagnostics, which are now colored by default, and accurate with multibyte input. Their form