Re: Policy on adding timeouts to tests

2014-04-16 Thread Andrew Wang
The timeouts are nice when trying to debug test failures on Jenkins, because otherwise you just see something like this: Caused by: java.lang.RuntimeException: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? We still see this today because some tests lac

Re: Policy on adding timeouts to tests

2014-04-16 Thread Tsuyoshi OZAWA
Hi Karthik, Some tests with servers like MiniCluster or ZK can never end because of unexpected busy loop or something if the tests don't have timeouts. It can blocks the other jobs of Jenkins server. Therefore, IMHO, we should add timeouts when we write tests with them. Thanks, - Tsuyoshi On Wed

Re: Policy on adding timeouts to tests

2014-04-16 Thread Steve Loughran
There's a JIRA somewhere that 's never gone in, to add a timeout rule to a base class; this rule gets picked up in that test class and all children to specify the timeout @Rule public final Timeout testTimeout = new Timeout(TEST_TIMEOUT); 1. If we are going to have a timeout everywhere, i