Re: Merge Namenode HA feature to 0.23

2012-03-09 Thread Eli Collins
Hey Suresh, Forgot to ask, when do you plan to check this into branch-23? Will delay any merges that might conflict with this until you've committed it. Thanks, Eli On Fri, Mar 9, 2012 at 10:08 AM, Eli Collins wrote: > Hey Suresh, > > Went through the patch, looks good to me. Put a +1 on jira.

Re: Merge Namenode HA feature to 0.23

2012-03-09 Thread Eli Collins
Hey Suresh, Went through the patch, looks good to me. Put a +1 on jira. Thanks, Eli On Wed, Mar 7, 2012 at 9:26 PM, Suresh Srinivas wrote: > I have merged the change required for merging Namenode HA. I have also > attached a release 23 patch in the jira HDFS-1623. Please take a look the > attac

Re: Merge Namenode HA feature to 0.23

2012-03-08 Thread Aaron T. Myers
+1 I applied the patch to branch-0.23. It compiles just fine. I built a distribution tar, deployed it to a 4-node cluster, and ran some smoke tests with HA enabled. All seemed good. I also ran the following unit tests, which should exercise the relevant HA code: TestOfflineEditsViewer,TestHDFSCo

Re: Merge Namenode HA feature to 0.23

2012-03-07 Thread Suresh Srinivas
I have merged the change required for merging Namenode HA. I have also attached a release 23 patch in the jira HDFS-1623. Please take a look the attached patch and let me know if that looks good. Regards, Suresh

Re: Merge Namenode HA feature to 0.23

2012-03-07 Thread Eli Collins
+1. Thanks Suresh, those lgtm On Wednesday, March 7, 2012, Suresh Srinivas wrote: > Thanks Eli for the list. I have merged the bugs you identified to 0.23. I > am in the process of merging HA change. I have several conflicts, stemming > from the changes that are no in 0.23. Pushing following ji

Re: Merge Namenode HA feature to 0.23

2012-03-07 Thread Aaron T. Myers
Likewise, +1 to merging all of those. HADOOP-7717 and HDFS-2430 are hard requirements for the HA work, and the rest of those seem like strict improvements to me. If they make the merge easier, then by all means do it. I don't think you need to wait a day, either. I doubt anyone will object to merg

Re: Merge Namenode HA feature to 0.23

2012-03-07 Thread Todd Lipcon
+1 on merging all of those On Wed, Mar 7, 2012 at 1:12 AM, Suresh Srinivas wrote: > Thanks Eli for the list. I have merged the bugs you identified to 0.23. I > am in the process of merging HA change. I have several conflicts, stemming > from the changes that are no in 0.23. Pushing following jira

Re: Merge Namenode HA feature to 0.23

2012-03-07 Thread Suresh Srinivas
Thanks Eli for the list. I have merged the bugs you identified to 0.23. I am in the process of merging HA change. I have several conflicts, stemming from the changes that are no in 0.23. Pushing following jiras to 0.23 will make the merge easier. I believe these are mostly straight forward changes:

Re: Merge Namenode HA feature to 0.23

2012-03-04 Thread Eli Collins
Hey Suresh, +1 Sounds great. Thanks for volunteering! You'll probably want to merge HDFS-1580, HDFS-1765, HDFS-2158, HDFS-2188, HDFS-2334, HDFS-2476, HDFS-2477, and HDFS-2495 to branch-23 first as these conflict and the patch will contain a bunch of non-HA stuff. Thanks, Eli On Fri, Mar 2, 20

Re: Merge Namenode HA feature to 0.23

2012-03-04 Thread Aaron T. Myers
+1, this'll be great. The sooner the better. Please let me know if I can be of any help. Thanks a lot for volunteering to do this, Suresh. -- Aaron T. Myers Software Engineer, Cloudera On Fri, Mar 2, 2012 at 6:15 PM, Suresh Srinivas wrote: > Namenode HA (HDFS-1623) feature is now in trunk (ya

Re: Merge Namenode HA feature to 0.23

2012-03-02 Thread Arun Murthy
Awesome! +1! Sent from my iPhone On Mar 2, 2012, at 6:16 PM, Suresh Srinivas wrote: > Namenode HA (HDFS-1623) feature is now in trunk (yay!). It adds support for > namenode high availability with active and standby namenodes, with manual > failover. I propose merging this feature to 0.23 branch

Merge Namenode HA feature to 0.23

2012-03-02 Thread Suresh Srinivas
Namenode HA (HDFS-1623) feature is now in trunk (yay!). It adds support for namenode high availability with active and standby namenodes, with manual failover. I propose merging this feature to 0.23 branch. Recently Nicholas merged protocol buffers/wire compatibility changes to 0.23. Merging Nameno