Re: Jenkins stability and patching

2015-11-24 Thread Steve Loughran
> On 23 Nov 2015, at 21:57, Colin P. McCabe wrote: > > On Mon, Nov 23, 2015 at 1:53 PM, Colin P. McCabe wrote: >> I agree that our tests are in a bad state. It would help if we could >> maintain a list of "flaky tests" somewhere in git and have Yetus >> consider the flakiness of a test before

Re: Jenkins stability and patching

2015-11-23 Thread Colin P. McCabe
On Mon, Nov 23, 2015 at 1:53 PM, Colin P. McCabe wrote: > I agree that our tests are in a bad state. It would help if we could > maintain a list of "flaky tests" somewhere in git and have Yetus > consider the flakiness of a test before -1ing a patch. Right now, we > pretty much all have that lis

Re: Jenkins stability and patching

2015-11-23 Thread Colin P. McCabe
I agree that our tests are in a bad state. It would help if we could maintain a list of "flaky tests" somewhere in git and have Yetus consider the flakiness of a test before -1ing a patch. Right now, we pretty much all have that list in our heads, and we're not applying it very consistently. Hav

Re: Jenkins stability and patching

2015-11-22 Thread Tsuyoshi Ozawa
Thank you for starting discussion, Steve. It sounds good to me. I'll check the test failures. - Tsuyoshi On Sun, Nov 22, 2015 at 9:21 PM, Steve Loughran wrote: > > Jenkins is pretty much dead in the water these days; a test run that works is > a rare miracle rather than the default state. Whic

Jenkins stability and patching

2015-11-22 Thread Steve Loughran
Jenkins is pretty much dead in the water these days; a test run that works is a rare miracle rather than the default state. Which also means most patches are being +1'd in even though patches are failing, with comments like "the test failures are probably unrelated" I think everyone has to be