Thanks for getting that list of examples together. That's a pretty good mix!
I went through these too without looking at Todd's comments first to avoid
prejudice. Here's my results..
1) ugly dangling ')'
6-7) would prefer 4 spaces before 'throws'
11-12) ok.
16-17) ok. I don't think we should manda
> So, IMO, the goal should be the examples on 10-24 or 31-36.
+1 I agree with Todd: the highlighted snippets are most appropriate as Java
coding style.
On 11/20/09 10:54 , Todd Lipcon wrote:
My opinions on the groups of line numbers from that pastebin:
1-3: Definitely not - no reason for ) o
My opinions on the groups of line numbers from that pastebin:
1-3: Definitely not - no reason for ) on its own line
5-8: no, "throws" should be indented
10-13: I think this is acceptable
15-19: also acceptable IMO
22-24: acceptable - lines wrapped due to column limit should indent their
wrappings
Hi,
I was trying to make a patch and looking over the Hadoop guidelines for code at
http://wiki.apache.org/hadoop/CodeReviewChecklist, trying to follow the
conventions.
Looking through code I found a few "patterns", however, these differ even in
the same class sometimes. Here's a collection of
