Re: Hadoop-2 generics compilation error

2012-06-29 Thread Andy Isaacson
_ > > From: Alejandro Abdelnur > > To: hdfs-dev@hadoop.apache.org > > Sent: Friday, June 29, 2012 3:26 PM > > Subject: Re: Hadoop-2 generics compilation error > > > > Andy, > > > > It looks like OpenJDK javac does not handle type unboxing with a

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Alejandro Abdelnur
If so, changing this to reference types should make both JDKs happy. > > -- Lars > > > From: Alejandro Abdelnur > To: hdfs-dev@hadoop.apache.org > Sent: Friday, June 29, 2012 3:26 PM > Subject: Re: Hadoop-2 generics compilation error > > A

Re: Hadoop-2 generics compilation error

2012-06-29 Thread lars hofhansl
SunJDK will correctly infer the reference types, correct? If so, changing this to reference types should make both JDKs happy. -- Lars From: Alejandro Abdelnur To: hdfs-dev@hadoop.apache.org Sent: Friday, June 29, 2012 3:26 PM Subject: Re: Hadoop-2 generics

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Alejandro Abdelnur
Andy, It looks like OpenJDK javac does not handle type unboxing with a generic method where the parameter that resolves the generic infers the type to do the un-boxing on. While SunJDK does handle it. Now, to the question which one is correct? I'm not sure but SunJDK does a valid inference. thx

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Andy Isaacson
I've filed https://issues.apache.org/jira/browse/HDFS-3580 and attached the patch. I'd really appreciate it if someone could explain what the problem is, why the patch fixes it, and whether this is a bug in OpenJDK (that it does not accept a valid program) or a bug in Sun JDK (that it does accept

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Andy Isaacson
I ran into this as well, and am prepping a patch. Lars, if you could file the Jira explaining why s/boolean/Boolean/ is the right fix, I'll test and submit the patch. -andy On Fri, Jun 29, 2012 at 11:08 AM, Alejandro Abdelnur wrote: > This change is from HDFS-3481, the wrong JIRA number is becau

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Alejandro Abdelnur
This change is from HDFS-3481, the wrong JIRA number is because I made a mistake in the commit message. I can put a patch to fix this, but don't have OpenJDK to test it. It would be better if somebody with OpenJDK takes care of it and I'll review it. Thx On Fri, Jun 29, 2012 at 11:01 AM, Arun C

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Arun C Murthy
HDFS-3113 is committed? Or, are you running with the patch yourself? It's still PA and I see Daryn reviewing it yet... Arun On Jun 28, 2012, at 10:27 PM, lars hofhansl wrote: > Since HDFS-3113 was integrated into Hadoop-2 I get the compilation errors of > the following type: > > [ERROR] > /h

Re: Hadoop-2 generics compilation error

2012-06-29 Thread Eli Collins
Sounds reasonable, file a jira/patch? On Thursday, June 28, 2012, lars hofhansl wrote: > Since HDFS-3113 was integrated into Hadoop-2 I get the compilation errors > of the following type: > > [ERROR] > /home/lars/dev/hadoop-2/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/

Hadoop-2 generics compilation error

2012-06-28 Thread lars hofhansl
Since HDFS-3113 was integrated into Hadoop-2 I get the compilation errors of the following type: [ERROR] /home/lars/dev/hadoop-2/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java:[407,36] incompatible types; no instance(s) of type variable(s