Re: Changes to FSImage/FSEditLog

2010-11-28 Thread Eli Collins
Hey Todd, Ivan, I've committed the patch for 1473. Thanks, Eli On Wed, Nov 24, 2010 at 2:25 PM, Todd Lipcon wrote: > Hi all, > > There's a patch up for 1473 now. If we can get a +1 we can commit this and > move on to the next steps in some of these projects. > > Thanks > -Todd > > On Thu, Nov 1

Re: Changes to FSImage/FSEditLog

2010-11-24 Thread Todd Lipcon
Hi all, There's a patch up for 1473 now. If we can get a +1 we can commit this and move on to the next steps in some of these projects. Thanks -Todd On Thu, Nov 18, 2010 at 12:42 AM, Ivan Kelly wrote: > This patch looks really good. It shouldn't affect our refactoring too much > and will actua

Re: Changes to FSImage/FSEditLog

2010-11-18 Thread Jakob Homan
Glancing at 1473, it seems reasonable, but of course should get a thorough review. HDFS-1465 will impact and essentially replace all the saving/loading code, so whether the it does so with the code's current state or with 1473's refactoring, it doesn't matter much. 1473 will probably make it

Re: Changes to FSImage/FSEditLog

2010-11-18 Thread Ivan Kelly
This patch looks really good. It shouldn't affect our refactoring too much and will actually make things a lot easier for the next part (breaking the circular dependency between namesystem and fsimage). -Ivan On 18 Nov 2010, at 02:27, Todd Lipcon wrote: I put up a sketch of a patch for 1473. I

Re: Changes to FSImage/FSEditLog

2010-11-17 Thread Todd Lipcon
I put up a sketch of a patch for 1473. It compiles and passes at least a couple of the unit tests, but more work to be done on it. Would appreciate comments from this crowd if the new classes seem like good divisions. -Todd On Wed, Nov 17, 2010 at 2:36 PM, Todd Lipcon wrote: > On Wed, Nov 17, 2

Re: Changes to FSImage/FSEditLog

2010-11-17 Thread Todd Lipcon
Sure, moving this discussion to the public list. It was only a private discussion because I find people tend to notice messages in their inbox more than on JIRA or a list ;-) -Todd On Wed, Nov 17, 2010 at 4:41 PM, Jakob Homan wrote: > Can this message please be re-posted to the hdfs-dev list, s