[RESULT] Re: [VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-22 Thread Anu Engineer
Hi All, This vote passes with +4 binding votes. Thank you all for taking time out to review, test and contribute patches to disk balancer. Thanks Anu On 6/22/16, 3:41 PM, "Lei Xu" wrote: >Thanks for the great work, Anu. > >I have ran a test on a local cluster. One suggestion is that the CLI

Re: [VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-22 Thread Lei Xu
Thanks for the great work, Anu. I have ran a test on a local cluster. One suggestion is that the CLI help messages should be more consistent with the rest of rest of hdfs command line tools. +1 for the merge. On Wed, Jun 22, 2016 at 2:30 PM, Jitendra Pandey wrote: > I think this is a very usef

Re: [VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-22 Thread Jitendra Pandey
I think this is a very useful feature. I have file an improvement request, but that doesn’t block the merge. I think the core functionality is complete, with good test coverage and documentation. +1 for the merge. On Jun 22, 2016, at 12:28 AM, Arpit Agarwal wrote: > This feature is frequently

Re: [VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-22 Thread Arpit Agarwal
This feature is frequently requested by users and would be a useful addition to HDFS. I’ve code reviewed many of the sub-tasks and have tried out Disk Balancer in a test cluster. Suggested a couple of usability improvements. These are tracked by open Jiras but they need not hold up the merge. T

Re: [VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-21 Thread Tsz Wo Sze
+1 The code looks good in general.  It is great that there are a lot of tests and documentation.  Some minor comments which can be addressed after merge:- There are a few TODOs in the code.- Tried the  help command "hdfs diskbalancer -help plan".  There is a typo "wetolerate" in --thresholdPerce

[VOTE] HDFS-1312 - Diskbalancer branch merge

2016-06-15 Thread Anu Engineer
Hi All, I would like to propose a merge vote for HDFS-1312 (Disk balancer) branch to trunk. This branch creates a new tool that allows balancing of data on a datanode. The voting commences now and will run for 7 days till Jun/22/2016 5:00 PM PST. This tool distributes data evenly between the