Re: [DISCUSS] Prefer JUnit5 for new tests

2019-08-13 Thread Akira Ajisaka
My answer: JUnit 5 -> org.junit.jupiter.api.Test JUnit 4 -> org.junit.Test (JUnit 3 -> junit.framework.TestCase) I found there are still some tests written in JUnit 3 API... Sorry for the late reply. -Akira On Fri, Jul 26, 2019 at 8:37 PM Steve Loughran wrote: > > > this is a silly question,

Re: [DISCUSS] Prefer JUnit5 for new tests

2019-07-26 Thread Steve Loughran
this is a silly question, but what is a "Junit 5 test"? We've been slowly adopting the assertJ APIs in new tests in hadoop-aws, and they work file in the older codebase, so even for existing tests we can advocate them. they're very good for making assertions about collections; very verbose for cla

Re: [DISCUSS] Prefer JUnit5 for new tests

2019-07-26 Thread Vinod Kumar Vavilapalli
+1 if it is indeed possible to have both. Thanks +Vinod > On Jul 26, 2019, at 1:56 PM, Akira Ajisaka wrote: > > Hi folks, > > Now we are slowly migrating from JUnit4 to JUnit5. > https://issues.apache.org/jira/browse/HADOOP-14693 > > However, as Steve commented [1], if we are going to migrate

[DISCUSS] Prefer JUnit5 for new tests

2019-07-26 Thread Akira Ajisaka
Hi folks, Now we are slowly migrating from JUnit4 to JUnit5. https://issues.apache.org/jira/browse/HADOOP-14693 However, as Steve commented [1], if we are going to migrate the existing tests, the backporting cost will become too expensive. Therefore, I'd like to recommend using JUnit5 for new tes